Skip to content

Commit

Permalink
hw/pci: define msi_nonbroken in pci-stub
Browse files Browse the repository at this point in the history
The kludged field 'msi_nonbroken' is declared in "hw/pci/msi.h" and defined in
hw/pci/msi.c.
When using an ARM config with CONFIG_PCI disabled, hw/pci/msi.c is not included.
Without being PCI-related, the files hw/intc/arm_gicv[23*].c do access this
field (to enable the kludge if PCI is enabled).
The final link fails since hw/pci/msi.c is not included.
Defining this field in pci-stub is safe enough for configs without CONFIG_PCI.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
philmd authored and Michael Tokarev committed Jul 11, 2017
1 parent 8f7b1bd commit 6676756
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions hw/pci/pci-stub.c
Expand Up @@ -24,6 +24,9 @@
#include "qapi/qmp/qerror.h"
#include "hw/pci/pci.h"
#include "qmp-commands.h"
#include "hw/pci/msi.h"

bool msi_nonbroken;

PciInfoList *qmp_query_pci(Error **errp)
{
Expand Down

0 comments on commit 6676756

Please sign in to comment.