Skip to content

Commit

Permalink
linux-user: fix the errno value in print_syscall_err()
Browse files Browse the repository at this point in the history
errno of the target is returned as a negative value by the syscall,
not in the host errno variable.

The emulation of the target syscall can return an error while the
host doesn't set an errno value. Target errnos and host errnos can
also differ in some cases.

Fixes: c84be71 ("linux-user: Extend strace support to enable argument printing after syscall execution")
Cc: Filip.Bozuta@syrmia.com
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Filip Bozuta <Filip.Bozuta@syrmia.com>
Message-Id: <20200708152435.706070-2-laurent@vivier.eu>
  • Loading branch information
vivier committed Jul 14, 2020
1 parent 65b261a commit 6733d57
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion linux-user/strace.c
Expand Up @@ -731,7 +731,7 @@ print_syscall_err(abi_long ret)

qemu_log(" = ");
if (ret < 0) {
qemu_log("-1 errno=%d", errno);
qemu_log("-1 errno=%d", (int)-ret);
errstr = target_strerror(-ret);
if (errstr) {
qemu_log(" (%s)", errstr);
Expand Down

0 comments on commit 6733d57

Please sign in to comment.