Skip to content

Commit

Permalink
target-sparc: fix 32bit integer division overflow
Browse files Browse the repository at this point in the history
The signed integer division -0x8000_0000_0000_0000 / -1 must be handled
separately to avoid an overflow on the QEMU host.

Negative overflow must be a negative number for correct sign
extension in Sparc64 mode. Use <stdint.h> constants.

Signed-off-by: Olivier Danet <odanet@caramail.com>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  • Loading branch information
Olivier Danet authored and mcayland committed Mar 26, 2014
1 parent db237e3 commit 6a5b69a
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions target-sparc/helper.c
Expand Up @@ -85,8 +85,8 @@ static target_ulong helper_udiv_common(CPUSPARCState *env, target_ulong a,
}

x0 = x0 / x1;
if (x0 > 0xffffffff) {
x0 = 0xffffffff;
if (x0 > UINT32_MAX) {
x0 = UINT32_MAX;
overflow = 1;
}

Expand Down Expand Up @@ -122,12 +122,15 @@ static target_ulong helper_sdiv_common(CPUSPARCState *env, target_ulong a,
if (x1 == 0) {
cpu_restore_state(CPU(cpu), GETPC());
helper_raise_exception(env, TT_DIV_ZERO);
}

x0 = x0 / x1;
if ((int32_t) x0 != x0) {
x0 = x0 < 0 ? 0x80000000 : 0x7fffffff;
} else if (x1 == -1 && x0 == INT64_MIN) {
x0 = INT32_MAX;
overflow = 1;
} else {
x0 = x0 / x1;
if ((int32_t) x0 != x0) {
x0 = x0 < 0 ? INT32_MIN : INT32_MAX;
overflow = 1;
}
}

if (cc) {
Expand Down

0 comments on commit 6a5b69a

Please sign in to comment.