Skip to content

Commit

Permalink
audio: Add braces for statements/fix braces' position
Browse files Browse the repository at this point in the history
Fix problems about braces:
-braces are necessary for all arms of if/for/while statements
-else should follow close brace '}'

Signed-off-by: Zhang Han <zhanghan64@huawei.com>
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Message-Id: <20210115012431.79533-2-zhanghan64@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  • Loading branch information
Zhang Han authored and kraxel committed Jan 15, 2021
1 parent 2d96a00 commit 6c6886b
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 48 deletions.
15 changes: 5 additions & 10 deletions audio/alsaaudio.c
Expand Up @@ -278,32 +278,28 @@ static snd_pcm_format_t aud_to_alsafmt (AudioFormat fmt, int endianness)
case AUDIO_FORMAT_S16:
if (endianness) {
return SND_PCM_FORMAT_S16_BE;
}
else {
} else {
return SND_PCM_FORMAT_S16_LE;
}

case AUDIO_FORMAT_U16:
if (endianness) {
return SND_PCM_FORMAT_U16_BE;
}
else {
} else {
return SND_PCM_FORMAT_U16_LE;
}

case AUDIO_FORMAT_S32:
if (endianness) {
return SND_PCM_FORMAT_S32_BE;
}
else {
} else {
return SND_PCM_FORMAT_S32_LE;
}

case AUDIO_FORMAT_U32:
if (endianness) {
return SND_PCM_FORMAT_U32_BE;
}
else {
} else {
return SND_PCM_FORMAT_U32_LE;
}

Expand Down Expand Up @@ -722,8 +718,7 @@ static int alsa_voice_ctl (snd_pcm_t *handle, const char *typ, int ctl)
alsa_logerr (err, "Could not stop %s\n", typ);
return -1;
}
}
else {
} else {
err = snd_pcm_prepare (handle);
if (err < 0) {
alsa_logerr (err, "Could not prepare handle for %s\n", typ);
Expand Down
26 changes: 12 additions & 14 deletions audio/audio.c
Expand Up @@ -344,8 +344,7 @@ void audio_pcm_info_clear_buf (struct audio_pcm_info *info, void *buf, int len)

if (info->is_signed || info->is_float) {
memset(buf, 0x00, len * info->bytes_per_frame);
}
else {
} else {
switch (info->bits) {
case 8:
memset(buf, 0x80, len * info->bytes_per_frame);
Expand Down Expand Up @@ -584,8 +583,7 @@ static size_t audio_pcm_sw_get_rpos_in(SWVoiceIn *sw)
rpos = hw->conv_buf->pos - live;
if (rpos >= 0) {
return rpos;
}
else {
} else {
return hw->conv_buf->size + rpos;
}
}
Expand Down Expand Up @@ -788,10 +786,14 @@ static int audio_is_timer_needed(AudioState *s)
HWVoiceOut *hwo = NULL;

while ((hwo = audio_pcm_hw_find_any_enabled_out(s, hwo))) {
if (!hwo->poll_mode) return 1;
if (!hwo->poll_mode) {
return 1;
}
}
while ((hwi = audio_pcm_hw_find_any_enabled_in(s, hwi))) {
if (!hwi->poll_mode) return 1;
if (!hwi->poll_mode) {
return 1;
}
}
return 0;
}
Expand Down Expand Up @@ -908,8 +910,7 @@ void AUD_set_active_out (SWVoiceOut *sw, int on)
audio_reset_timer (s);
}
}
}
else {
} else {
if (hw->enabled) {
int nb_active = 0;

Expand Down Expand Up @@ -956,8 +957,7 @@ void AUD_set_active_in (SWVoiceIn *sw, int on)
}
}
sw->total_hw_samples_acquired = hw->total_samples_captured;
}
else {
} else {
if (hw->enabled) {
int nb_active = 0;

Expand Down Expand Up @@ -1532,8 +1532,7 @@ static int audio_driver_init(AudioState *s, struct audio_driver *drv,
audio_init_nb_voices_in(s, drv);
s->drv = drv;
return 0;
}
else {
} else {
if (msg) {
dolog("Could not init `%s' audio driver\n", drv->name);
}
Expand Down Expand Up @@ -1848,8 +1847,7 @@ CaptureVoiceOut *AUD_add_capture(
if (cap) {
QLIST_INSERT_HEAD (&cap->cb_head, cb, entries);
return cap;
}
else {
} else {
HWVoiceOut *hw;
CaptureVoiceOut *cap;

Expand Down
12 changes: 4 additions & 8 deletions audio/audio_template.h
Expand Up @@ -47,8 +47,7 @@ static void glue(audio_init_nb_voices_, TYPE)(AudioState *s,
#ifdef DAC
dolog ("Driver `%s' does not support " NAME "\n", drv->name);
#endif
}
else {
} else {
dolog ("Driver `%s' does not support %d " NAME " voices, max %d\n",
drv->name,
glue (s->nb_hw_voices_, TYPE),
Expand Down Expand Up @@ -387,8 +386,7 @@ static SW *glue(audio_pcm_create_voice_pair_, TYPE)(

if (pdo->fixed_settings) {
hw_as = audiodev_to_audsettings(pdo);
}
else {
} else {
hw_as = *as;
}

Expand Down Expand Up @@ -498,8 +496,7 @@ SW *glue (AUD_open_, TYPE) (
if (glue (audio_pcm_sw_init_, TYPE) (sw, hw, name, as)) {
goto fail;
}
}
else {
} else {
sw = glue(audio_pcm_create_voice_pair_, TYPE)(s, name, as);
if (!sw) {
dolog ("Failed to create voice `%s'\n", name);
Expand Down Expand Up @@ -553,8 +550,7 @@ uint64_t glue (AUD_get_elapsed_usec_, TYPE) (SW *sw, QEMUAudioTimeStamp *ts)

if (cur_ts >= old_ts) {
delta = cur_ts - old_ts;
}
else {
} else {
delta = UINT64_MAX - old_ts + cur_ts;
}

Expand Down
3 changes: 1 addition & 2 deletions audio/coreaudio.c
Expand Up @@ -524,8 +524,7 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,
} else if (frameRange.mMaximum < frames) {
core->audioDevicePropertyBufferFrameSize = (UInt32) frameRange.mMaximum;
dolog ("warning: Downsizing Buffer Frames to %f\n", frameRange.mMaximum);
}
else {
} else {
core->audioDevicePropertyBufferFrameSize = frames;
}

Expand Down
9 changes: 3 additions & 6 deletions audio/dsoundaudio.c
Expand Up @@ -404,8 +404,7 @@ static void dsound_enable_out(HWVoiceOut *hw, bool enable)
dsound_logerr (hr, "Could not stop playing buffer\n");
return;
}
}
else {
} else {
dolog ("warning: Voice is not playing\n");
}
}
Expand Down Expand Up @@ -509,8 +508,7 @@ static void dsound_enable_in(HWVoiceIn *hw, bool enable)
dsound_logerr (hr, "Could not stop capturing\n");
return;
}
}
else {
} else {
dolog ("warning: Voice is not capturing\n");
}
}
Expand Down Expand Up @@ -659,8 +657,7 @@ static void *dsound_audio_init(Audiodev *dev)
);
if (FAILED (hr)) {
dsound_logerr (hr, "Could not create DirectSoundCapture instance\n");
}
else {
} else {
hr = IDirectSoundCapture_Initialize (s->dsound_capture, NULL);
if (FAILED (hr)) {
dsound_logerr (hr, "Could not initialize DirectSoundCapture\n");
Expand Down
12 changes: 4 additions & 8 deletions audio/ossaudio.c
Expand Up @@ -142,16 +142,14 @@ static int aud_to_ossfmt (AudioFormat fmt, int endianness)
case AUDIO_FORMAT_S16:
if (endianness) {
return AFMT_S16_BE;
}
else {
} else {
return AFMT_S16_LE;
}

case AUDIO_FORMAT_U16:
if (endianness) {
return AFMT_U16_BE;
}
else {
} else {
return AFMT_U16_LE;
}

Expand Down Expand Up @@ -542,16 +540,14 @@ static int oss_init_out(HWVoiceOut *hw, struct audsettings *as,
int trig = 0;
if (ioctl (fd, SNDCTL_DSP_SETTRIGGER, &trig) < 0) {
oss_logerr (errno, "SNDCTL_DSP_SETTRIGGER 0 failed\n");
}
else {
} else {
trig = PCM_ENABLE_OUTPUT;
if (ioctl (fd, SNDCTL_DSP_SETTRIGGER, &trig) < 0) {
oss_logerr (
errno,
"SNDCTL_DSP_SETTRIGGER PCM_ENABLE_OUTPUT failed\n"
);
}
else {
} else {
oss->mmapped = 1;
}
}
Expand Down

0 comments on commit 6c6886b

Please sign in to comment.