Skip to content

Commit

Permalink
vdpa: Adapt vhost_vdpa_get_vring_base to SVQ
Browse files Browse the repository at this point in the history
This is needed to achieve migration, so the destination can restore its
index.

Setting base as last used idx, so destination will see as available all
the entries that the device did not use, including the in-flight
processing ones.

This is ok for networking, but other kinds of devices might have
problems with these retransmissions.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
  • Loading branch information
eugpermar authored and jasowang committed Mar 15, 2022
1 parent 34e3c94 commit 6d0b222
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions hw/virtio/vhost-vdpa.c
Expand Up @@ -1141,8 +1141,25 @@ static int vhost_vdpa_set_vring_base(struct vhost_dev *dev,
static int vhost_vdpa_get_vring_base(struct vhost_dev *dev,
struct vhost_vring_state *ring)
{
struct vhost_vdpa *v = dev->opaque;
int ret;

if (v->shadow_vqs_enabled) {
VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs,
ring->index);

/*
* Setting base as last used idx, so destination will see as available
* all the entries that the device did not use, including the in-flight
* processing ones.
*
* TODO: This is ok for networking, but other kinds of devices might
* have problems with these retransmissions.
*/
ring->num = svq->last_used_idx;
return 0;
}

ret = vhost_vdpa_call(dev, VHOST_GET_VRING_BASE, ring);
trace_vhost_vdpa_get_vring_base(dev, ring->index, ring->num);
return ret;
Expand Down

0 comments on commit 6d0b222

Please sign in to comment.