Skip to content

Commit

Permalink
i386: hvf: remove ZERO_INIT macro
Browse files Browse the repository at this point in the history
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
bonzini committed Dec 22, 2017
1 parent 7468278 commit 715f396
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
5 changes: 3 additions & 2 deletions target/i386/hvf/x86.c
Expand Up @@ -53,7 +53,8 @@ bool x86_read_segment_descriptor(struct CPUState *cpu,
addr_t base;
uint32_t limit;

ZERO_INIT(*desc);
memset(desc, 0, sizeof(*desc));

/* valid gdt descriptors start from index 1 */
if (!sel.index && GDT_SEL == sel.ti) {
return false;
Expand Down Expand Up @@ -104,7 +105,7 @@ bool x86_read_call_gate(struct CPUState *cpu, struct x86_call_gate *idt_desc,
addr_t base = rvmcs(cpu->hvf_fd, VMCS_GUEST_IDTR_BASE);
uint32_t limit = rvmcs(cpu->hvf_fd, VMCS_GUEST_IDTR_LIMIT);

ZERO_INIT(*idt_desc);
memset(idt_desc, 0, sizeof(*idt_desc));
if (gate * 8 >= limit) {
printf("%s: idt limit\n", __func__);
return false;
Expand Down
3 changes: 1 addition & 2 deletions target/i386/hvf/x86_decode.c
Expand Up @@ -2091,8 +2091,7 @@ static void decode_opcodes(CPUX86State *env, struct x86_decode *decode)

uint32_t decode_instruction(CPUX86State *env, struct x86_decode *decode)
{
ZERO_INIT(*decode);

memset(decode, 0, sizeof(*decode));
decode_prefix(env, decode);
set_addressing_size(env, decode);
set_operand_size(env, decode);
Expand Down
2 changes: 0 additions & 2 deletions target/i386/hvf/x86_gen.h
Expand Up @@ -44,6 +44,4 @@ typedef uint64_t addr_t;
} \
}

#define ZERO_INIT(obj) memset((void *) &obj, 0, sizeof(obj))

#endif

0 comments on commit 715f396

Please sign in to comment.