Skip to content

Commit

Permalink
BootLinuxSshTest: Only use 'test' for unittest.TestCase method names
Browse files Browse the repository at this point in the history
In commit f6e501a, Eduardo started to use "check_" as a
prefix for methods of similar purpose. Follow this prior art,
since it might become the conventions when writting Avocado
tests.

Suggested-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190607174953.22342-1-philmd@redhat.com>
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  • Loading branch information
philmd authored and ehabkost committed Aug 27, 2019
1 parent 23919dd commit 73a5a77
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tests/acceptance/linux_ssh_mips_malta.py
Expand Up @@ -162,7 +162,7 @@ def run_common_commands(self):
self.assertIn(True, ["0dfbe8aa4c20b52e1b8bf3cb6cbdf193" in line
for line in stdout])

def do_test_mips_malta(self, endianess, kernel_path, uname_m):
def check_mips_malta(self, endianess, kernel_path, uname_m):
self.boot_debian_wheezy_image_and_ssh_login(endianess, kernel_path)

stdout, stderr = self.ssh_command('uname -a')
Expand All @@ -184,7 +184,7 @@ def test_mips_malta32eb_kernel3_2_0(self):
kernel_hash = '592e384a4edc16dade52a6cd5c785c637bcbc9ad'
kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)

self.do_test_mips_malta('be', kernel_path, 'mips')
self.check_mips_malta('be', kernel_path, 'mips')

@skipIf(os.getenv('CONTINUOUS_INTEGRATION'), 'Running on Travis-CI')
def test_mips_malta32el_kernel3_2_0(self):
Expand All @@ -199,7 +199,7 @@ def test_mips_malta32el_kernel3_2_0(self):
kernel_hash = 'a66bea5a8adaa2cb3d36a1d4e0ccdb01be8f6c2a'
kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)

self.do_test_mips_malta('le', kernel_path, 'mips')
self.check_mips_malta('le', kernel_path, 'mips')

@skipIf(os.getenv('CONTINUOUS_INTEGRATION'), 'Running on Travis-CI')
def test_mips_malta64eb_kernel3_2_0(self):
Expand All @@ -213,7 +213,7 @@ def test_mips_malta64eb_kernel3_2_0(self):
'vmlinux-3.2.0-4-5kc-malta')
kernel_hash = 'db6eea7de35d36c77d8c165b6bcb222e16eb91db'
kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
self.do_test_mips_malta('be', kernel_path, 'mips64')
self.check_mips_malta('be', kernel_path, 'mips64')

@skipIf(os.getenv('CONTINUOUS_INTEGRATION'), 'Running on Travis-CI')
def test_mips_malta64el_kernel3_2_0(self):
Expand All @@ -227,4 +227,4 @@ def test_mips_malta64el_kernel3_2_0(self):
'vmlinux-3.2.0-4-5kc-malta')
kernel_hash = '6a7f77245acf231415a0e8b725d91ed2f3487794'
kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
self.do_test_mips_malta('le', kernel_path, 'mips64')
self.check_mips_malta('le', kernel_path, 'mips64')

0 comments on commit 73a5a77

Please sign in to comment.