Skip to content

Commit

Permalink
iotests: use -ccw on s390x for 051
Browse files Browse the repository at this point in the history
The default cpu model on s390x does not provide zPCI, which is
not yet wired up on tcg. Moreover, virtio-ccw is the standard
on s390x, so use the -ccw instead of the -pci versions of virtio
devices on s390x.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: QingFeng Hao <haoqf@linux.vnet.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
cohuck authored and kevmw committed Sep 26, 2017
1 parent f1d5516 commit 75f02ed
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
12 changes: 11 additions & 1 deletion tests/qemu-iotests/051
Expand Up @@ -103,7 +103,17 @@ echo
echo === Device without drive ===
echo

run_qemu -device virtio-scsi-pci -device scsi-hd
case "$QEMU_DEFAULT_MACHINE" in
s390-ccw-virtio)
virtio_scsi=virtio-scsi-ccw
;;
*)
virtio_scsi=virtio-scsi-pci
;;
esac

run_qemu -device $virtio_scsi -device scsi-hd |
sed -e "s/$virtio_scsi/VIRTIO_SCSI/"

echo
echo === Overriding backing file ===
Expand Down
2 changes: 1 addition & 1 deletion tests/qemu-iotests/051.out
Expand Up @@ -49,7 +49,7 @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2: Cannot specif

=== Device without drive ===

Testing: -device virtio-scsi-pci -device scsi-hd
Testing: -device VIRTIO_SCSI -device scsi-hd
QEMU X.Y.Z monitor - type 'help' for more information
(qemu) QEMU_PROG: -device scsi-hd: drive property not set

Expand Down
2 changes: 1 addition & 1 deletion tests/qemu-iotests/051.pc.out
Expand Up @@ -49,7 +49,7 @@ QEMU_PROG: -drive file=TEST_DIR/t.qcow2,driver=qcow2,format=qcow2: Cannot specif

=== Device without drive ===

Testing: -device virtio-scsi-pci -device scsi-hd
Testing: -device VIRTIO_SCSI -device scsi-hd
QEMU X.Y.Z monitor - type 'help' for more information
(qemu) QEMU_PROG: -device scsi-hd: drive property not set

Expand Down

0 comments on commit 75f02ed

Please sign in to comment.