Skip to content

Commit

Permalink
block/file-posix: Remove redundant statement in raw_handle_perm_lock()
Browse files Browse the repository at this point in the history
Clang static code analyzer show warning:
  block/file-posix.c:891:9: warning: Value stored to 'op' is never read
        op = RAW_PL_ABORT;
        ^    ~~~~~~~~~~~~

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200302130715.29440-5-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
  • Loading branch information
Kuhn-Chen authored and vivier committed Mar 9, 2020
1 parent 35c9453 commit 76e91cd
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion block/file-posix.c
Expand Up @@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs,
"Is another process using the image [%s]?\n",
bs->filename);
}
op = RAW_PL_ABORT;
/* fall through to unlock bytes. */
case RAW_PL_ABORT:
raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm,
Expand Down

0 comments on commit 76e91cd

Please sign in to comment.