Skip to content

Commit

Permalink
qapi: Inline check_name() into check_union()
Browse files Browse the repository at this point in the history
check_name() consists of check_name_is_str() and check_name_str().
check_union() relies on the latter to catch optional discriminators.
The next commit will replace that by a more straightforward check.
Inlining check_name() into check_union() now should make that easier
to review.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20190927134639.4284-16-armbru@redhat.com>
  • Loading branch information
Markus Armbruster committed Sep 28, 2019
1 parent e6f9678 commit 77daece
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions scripts/qapi/common.py
Expand Up @@ -897,8 +897,10 @@ def check_union(expr, info):

# The value of member 'discriminator' must name a non-optional
# member of the base struct.
check_name(discriminator, info,
"discriminator of flat union '%s'" % name)
check_name_is_str(discriminator, info,
"discriminator of flat union '%s'" % name)
check_name_str(discriminator, info,
"discriminator of flat union '%s'" % name)
discriminator_value = base_members.get(discriminator)
if not discriminator_value:
raise QAPISemError(info,
Expand Down

0 comments on commit 77daece

Please sign in to comment.