Skip to content

Commit

Permalink
i386: Fix pkg_id offset for EPYC cpu models
Browse files Browse the repository at this point in the history
If the system is numa configured the pkg_offset needs
to be adjusted for EPYC cpu models. Fix it calling the
model specific handler.

Signed-off-by: Babu Moger <babu.moger@amd.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <158396725589.58170.16424607815207074485.stgit@naples-babu.amd.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  • Loading branch information
babumoger authored and ehabkost committed Mar 31, 2020
1 parent 247b18c commit 7b22576
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions hw/i386/pc.c
Expand Up @@ -1526,6 +1526,7 @@ static void pc_cpu_pre_plug(HotplugHandler *hotplug_dev,

env->nr_dies = x86ms->smp_dies;
env->nr_nodes = topo_info.nodes_per_pkg;
env->pkg_offset = x86ms->apicid_pkg_offset(&topo_info);

/*
* If APIC ID is not set,
Expand Down
4 changes: 2 additions & 2 deletions target/i386/cpu.c
Expand Up @@ -5610,7 +5610,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
*ecx |= CPUID_TOPOLOGY_LEVEL_SMT;
break;
case 1:
*eax = apicid_pkg_offset(&topo_info);
*eax = env->pkg_offset;
*ebx = cs->nr_cores * cs->nr_threads;
*ecx |= CPUID_TOPOLOGY_LEVEL_CORE;
break;
Expand Down Expand Up @@ -5644,7 +5644,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
*ecx |= CPUID_TOPOLOGY_LEVEL_CORE;
break;
case 2:
*eax = apicid_pkg_offset(&topo_info);
*eax = env->pkg_offset;
*ebx = env->nr_dies * cs->nr_cores * cs->nr_threads;
*ecx |= CPUID_TOPOLOGY_LEVEL_DIE;
break;
Expand Down
1 change: 1 addition & 0 deletions target/i386/cpu.h
Expand Up @@ -1610,6 +1610,7 @@ typedef struct CPUX86State {

unsigned nr_dies;
unsigned nr_nodes;
unsigned pkg_offset;
} CPUX86State;

struct kvm_msrs;
Expand Down

0 comments on commit 7b22576

Please sign in to comment.