Skip to content

Commit

Permalink
cutils: remove one unnecessary pointer operation
Browse files Browse the repository at this point in the history
Since we will not operate on the next address pointed by out, it is not
necessary to do addition on it.

After removing the operation, the function size reduced 16/18 bytes.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190610030852.16039-2-richardw.yang@linux.intel.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
  • Loading branch information
Wei Yang authored and Juan Quintela committed Jul 15, 2019
1 parent ca35380 commit 7c960d6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions util/cutils.c
Expand Up @@ -756,27 +756,27 @@ int uleb128_encode_small(uint8_t *out, uint32_t n)
{
g_assert(n <= 0x3fff);
if (n < 0x80) {
*out++ = n;
*out = n;
return 1;
} else {
*out++ = (n & 0x7f) | 0x80;
*out++ = n >> 7;
*out = n >> 7;
return 2;
}
}

int uleb128_decode_small(const uint8_t *in, uint32_t *n)
{
if (!(*in & 0x80)) {
*n = *in++;
*n = *in;
return 1;
} else {
*n = *in++ & 0x7f;
/* we exceed 14 bit number */
if (*in & 0x80) {
return -1;
}
*n |= *in++ << 7;
*n |= *in << 7;
return 2;
}
}
Expand Down

0 comments on commit 7c960d6

Please sign in to comment.