Skip to content

Commit

Permalink
s390x/cpumodel: factor out determination of default model name
Browse files Browse the repository at this point in the history
Now we can drop inclusion of "sysemu/kvm.h" from "s390-virtio.c".

Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20170818114353.13455-7-david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
  • Loading branch information
davidhildenbrand authored and cohuck committed Aug 30, 2017
1 parent fe7cb8e commit 7d00bf9
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
7 changes: 1 addition & 6 deletions hw/s390x/s390-virtio.c
Expand Up @@ -33,7 +33,6 @@
#include "hw/boards.h"
#include "hw/loader.h"
#include "hw/virtio/virtio.h"
#include "sysemu/kvm.h"
#include "exec/address-spaces.h"
#include "sysemu/qtest.h"

Expand Down Expand Up @@ -93,11 +92,7 @@ void s390_init_cpus(MachineState *machine)
gchar *name;

if (machine->cpu_model == NULL) {
if (kvm_enabled()) {
machine->cpu_model = "host";
} else {
machine->cpu_model = "qemu";
}
machine->cpu_model = s390_default_cpu_model_name();
}

cpu_states = g_new0(S390CPU *, max_cpus);
Expand Down
1 change: 1 addition & 0 deletions target/s390x/cpu.h
Expand Up @@ -647,6 +647,7 @@ void s390_cpu_model_register_props(Object *obj);
void s390_cpu_model_class_register_props(ObjectClass *oc);
void s390_realize_cpu_model(CPUState *cs, Error **errp);
ObjectClass *s390_cpu_class_by_name(const char *name);
const char *s390_default_cpu_model_name(void);

#define EXCP_EXT 1 /* external interrupt */
#define EXCP_SVC 2 /* supervisor call (syscall) */
Expand Down
8 changes: 8 additions & 0 deletions target/s390x/cpu_models.c
Expand Up @@ -1200,6 +1200,14 @@ ObjectClass *s390_cpu_class_by_name(const char *name)
return oc;
}

const char *s390_default_cpu_model_name(void)
{
if (kvm_enabled()) {
return "host";
}
return "qemu";
}

static const TypeInfo qemu_s390_cpu_type_info = {
.name = S390_CPU_TYPE_NAME("qemu"),
.parent = TYPE_S390_CPU,
Expand Down

0 comments on commit 7d00bf9

Please sign in to comment.