Skip to content

Commit

Permalink
char: rename some frontend functions
Browse files Browse the repository at this point in the history
qemu_chr_accept_input() and qemu_chr_disconnect() are only used by
frontend, so use qemu_chr_fe prefix.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20161022095318.17775-14-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
elmarco authored and bonzini committed Oct 24, 2016
1 parent 32a6ebe commit 7fa47e2
Show file tree
Hide file tree
Showing 18 changed files with 27 additions and 27 deletions.
2 changes: 1 addition & 1 deletion hw/char/bcm2835_aux.c
Expand Up @@ -80,7 +80,7 @@ static uint64_t bcm2835_aux_read(void *opaque, hwaddr offset, unsigned size)
}
}
if (s->chr.chr) {
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
bcm2835_aux_update(s);
return c;
Expand Down
4 changes: 2 additions & 2 deletions hw/char/cadence_uart.c
Expand Up @@ -143,7 +143,7 @@ static void uart_rx_reset(CadenceUARTState *s)
s->rx_wpos = 0;
s->rx_count = 0;
if (s->chr.chr) {
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
}

Expand Down Expand Up @@ -369,7 +369,7 @@ static void uart_read_rx_fifo(CadenceUARTState *s, uint32_t *c)
s->rx_count--;

if (s->chr.chr) {
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
} else {
*c = 0;
Expand Down
2 changes: 1 addition & 1 deletion hw/char/escc.c
Expand Up @@ -600,7 +600,7 @@ static uint64_t escc_mem_read(void *opaque, hwaddr addr,
ret = s->rx;
trace_escc_mem_readb_data(CHN_C(s), ret);
if (s->chr.chr) {
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
return ret;
default:
Expand Down
4 changes: 2 additions & 2 deletions hw/char/imx_serial.c
Expand Up @@ -122,7 +122,7 @@ static uint64_t imx_serial_read(void *opaque, hwaddr offset,
s->uts1 |= UTS1_RXEMPTY;
imx_update(s);
if (s->chr.chr) {
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
}
return c;
Expand Down Expand Up @@ -216,7 +216,7 @@ static void imx_serial_write(void *opaque, hwaddr offset,
if (value & UCR2_RXEN) {
if (!(s->ucr2 & UCR2_RXEN)) {
if (s->chr.chr) {
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion hw/char/ipoctal232.c
Expand Up @@ -289,7 +289,7 @@ static uint16_t io_read(IPackDevice *ip, uint8_t addr)
ch->sr &= ~SR_RXRDY;
blk->isr &= ~ISR_RXRDY(channel);
if (ch->dev.chr) {
qemu_chr_accept_input(ch->dev.chr);
qemu_chr_fe_accept_input(ch->dev.chr);
}
} else {
ch->rhr_idx = (ch->rhr_idx + 1) % RX_FIFO_SIZE;
Expand Down
2 changes: 1 addition & 1 deletion hw/char/lm32_uart.c
Expand Up @@ -142,7 +142,7 @@ static uint64_t uart_read(void *opaque, hwaddr addr,
r = s->regs[R_RXTX];
s->regs[R_LSR] &= ~LSR_DR;
uart_update_irq(s);
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
break;
case R_IIR:
case R_LSR:
Expand Down
2 changes: 1 addition & 1 deletion hw/char/mcf_uart.c
Expand Up @@ -93,7 +93,7 @@ uint64_t mcf_uart_read(void *opaque, hwaddr addr,
if (s->fifo_len == 0)
s->sr &= ~MCF_UART_RxRDY;
mcf_uart_update(s);
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
return val;
}
case 0x10:
Expand Down
2 changes: 1 addition & 1 deletion hw/char/milkymist-uart.c
Expand Up @@ -138,7 +138,7 @@ static void uart_write(void *opaque, hwaddr addr, uint64_t value,
case R_STAT:
/* write one to clear bits */
s->regs[addr] &= ~(value & (STAT_RX_EVT | STAT_TX_EVT));
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
break;

default:
Expand Down
2 changes: 1 addition & 1 deletion hw/char/pl011.c
Expand Up @@ -88,7 +88,7 @@ static uint64_t pl011_read(void *opaque, hwaddr offset,
s->rsr = c >> 8;
pl011_update(s);
if (s->chr.chr) {
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
r = c;
break;
Expand Down
2 changes: 1 addition & 1 deletion hw/char/serial.c
Expand Up @@ -490,7 +490,7 @@ static uint64_t serial_ioport_read(void *opaque, hwaddr addr, unsigned size)
serial_update_irq(s);
if (!(s->mcr & UART_MCR_LOOP)) {
/* in loopback mode, don't receive any data */
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
}
break;
Expand Down
2 changes: 1 addition & 1 deletion hw/char/spapr_vty.c
Expand Up @@ -51,7 +51,7 @@ static int vty_getchars(VIOsPAPRDevice *sdev, uint8_t *buf, int max)
buf[n++] = dev->buf[dev->out++ % VTERM_BUFSIZE];
}

qemu_chr_accept_input(dev->chardev.chr);
qemu_chr_fe_accept_input(dev->chardev.chr);

return n;
}
Expand Down
4 changes: 2 additions & 2 deletions hw/char/stm32f2xx_usart.c
Expand Up @@ -98,15 +98,15 @@ static uint64_t stm32f2xx_usart_read(void *opaque, hwaddr addr,
retvalue = s->usart_sr;
s->usart_sr &= ~USART_SR_TC;
if (s->chr.chr) {
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
return retvalue;
case USART_DR:
DB_PRINT("Value: 0x%" PRIx32 ", %c\n", s->usart_dr, (char) s->usart_dr);
s->usart_sr |= USART_SR_TXE;
s->usart_sr &= ~USART_SR_RXNE;
if (s->chr.chr) {
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
}
qemu_set_irq(s->irq, 0);
return s->usart_dr & 0x3FF;
Expand Down
2 changes: 1 addition & 1 deletion hw/char/virtio-console.c
Expand Up @@ -123,7 +123,7 @@ static void guest_writable(VirtIOSerialPort *port)
VirtConsole *vcon = VIRTIO_CONSOLE(port);

if (vcon->chr.chr) {
qemu_chr_accept_input(vcon->chr.chr);
qemu_chr_fe_accept_input(vcon->chr.chr);
}
}

Expand Down
2 changes: 1 addition & 1 deletion hw/char/xilinx_uartlite.c
Expand Up @@ -107,7 +107,7 @@ uart_read(void *opaque, hwaddr addr, unsigned int size)
s->rx_fifo_len--;
uart_update_status(s);
uart_update_irq(s);
qemu_chr_accept_input(s->chr.chr);
qemu_chr_fe_accept_input(s->chr.chr);
break;

default:
Expand Down
6 changes: 3 additions & 3 deletions include/sysemu/char.h
Expand Up @@ -165,11 +165,11 @@ CharDriverState *qemu_chr_new(const char *label, const char *filename);


/**
* @qemu_chr_disconnect:
* @qemu_chr_fe_disconnect:
*
* Close a fd accpeted by character backend.
*/
void qemu_chr_disconnect(CharDriverState *chr);
void qemu_chr_fe_disconnect(CharDriverState *chr);

/**
* @qemu_chr_cleanup:
Expand Down Expand Up @@ -490,7 +490,7 @@ void qemu_chr_add_handlers_full(CharDriverState *s,
GMainContext *context);

void qemu_chr_be_generic_open(CharDriverState *s);
void qemu_chr_accept_input(CharDriverState *s);
void qemu_chr_fe_accept_input(CharDriverState *s);
int qemu_chr_add_client(CharDriverState *s, int fd);
CharDriverState *qemu_chr_find(const char *name);
bool chr_is_ringbuf(const CharDriverState *chr);
Expand Down
4 changes: 2 additions & 2 deletions net/vhost-user.c
Expand Up @@ -187,7 +187,7 @@ static gboolean net_vhost_user_watch(GIOChannel *chan, GIOCondition cond,
{
VhostUserState *s = opaque;

qemu_chr_disconnect(s->chr.chr);
qemu_chr_fe_disconnect(s->chr.chr);

return FALSE;
}
Expand All @@ -212,7 +212,7 @@ static void net_vhost_user_event(void *opaque, int event)
s->watch = qemu_chr_fe_add_watch(s->chr.chr, G_IO_HUP,
net_vhost_user_watch, s);
if (vhost_user_start(queues, ncs) < 0) {
qemu_chr_disconnect(s->chr.chr);
qemu_chr_fe_disconnect(s->chr.chr);
return;
}
qmp_set_link(name, true, &err);
Expand Down
4 changes: 2 additions & 2 deletions qemu-char.c
Expand Up @@ -430,7 +430,7 @@ int qemu_chr_add_client(CharDriverState *s, int fd)
return s->chr_add_client ? s->chr_add_client(s, fd) : -1;
}

void qemu_chr_accept_input(CharDriverState *s)
void qemu_chr_fe_accept_input(CharDriverState *s)
{
if (s->chr_accept_input)
s->chr_accept_input(s);
Expand Down Expand Up @@ -4225,7 +4225,7 @@ void qemu_chr_fe_release(CharDriverState *s)
s->avail_connections++;
}

void qemu_chr_disconnect(CharDriverState *chr)
void qemu_chr_fe_disconnect(CharDriverState *chr)
{
if (chr->chr_disconnect) {
chr->chr_disconnect(chr);
Expand Down
6 changes: 3 additions & 3 deletions tests/vhost-user-test.c
Expand Up @@ -268,7 +268,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
int fd;

if (s->test_fail) {
qemu_chr_disconnect(chr->chr);
qemu_chr_fe_disconnect(chr->chr);
/* now switch to non-failure */
s->test_fail = false;
}
Expand Down Expand Up @@ -313,7 +313,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int size)
g_assert_cmpint(msg.payload.u64 & (0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES),
!=, 0ULL);
if (s->test_flags == TEST_FLAGS_DISCONNECT) {
qemu_chr_disconnect(chr->chr);
qemu_chr_fe_disconnect(chr->chr);
s->test_flags = TEST_FLAGS_BAD;
}
break;
Expand Down Expand Up @@ -724,7 +724,7 @@ reconnect_cb(gpointer user_data)
{
TestServer *s = user_data;

qemu_chr_disconnect(s->chr.chr);
qemu_chr_fe_disconnect(s->chr.chr);

return FALSE;
}
Expand Down

0 comments on commit 7fa47e2

Please sign in to comment.