Skip to content

Commit

Permalink
target/s390x/cpu_models: Rework the output of "-cpu help"
Browse files Browse the repository at this point in the history
Printing an "s390x" in front of each CPU name is not helpful at all:
It is confusing for the users since they don't know whether they
have to specify these letters for the "-cpu" parameter, too, and
it also takes some precious space in the dense output of the CPU
entries. Let's simply remove this now!

While we're at it, use two spaces at the beginning of the lines for
the indentation of the entries, and add a "Available CPUs" in the
very first line, like most other target architectures are doing it
for their "-cpu help" output already.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
huth authored and Michael Tokarev committed Apr 29, 2024
1 parent 4984321 commit 7febce3
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions target/s390x/cpu_models.c
Original file line number Diff line number Diff line change
Expand Up @@ -355,9 +355,9 @@ static void s390_print_cpu_model_list_entry(gpointer data, gpointer user_data)
/* strip off the -s390x-cpu */
g_strrstr(name, "-" TYPE_S390_CPU)[0] = 0;
if (details->len) {
qemu_printf("s390 %-15s %-35s (%s)\n", name, scc->desc, details->str);
qemu_printf(" %-15s %-35s (%s)\n", name, scc->desc, details->str);
} else {
qemu_printf("s390 %-15s %-35s\n", name, scc->desc);
qemu_printf(" %-15s %-35s\n", name, scc->desc);
}
g_free(name);
}
Expand Down Expand Up @@ -402,6 +402,7 @@ void s390_cpu_list(void)
S390Feat feat;
GSList *list;

qemu_printf("Available CPUs:\n");
list = object_class_get_list(TYPE_S390_CPU, false);
list = g_slist_sort(list, s390_cpu_list_compare);
g_slist_foreach(list, s390_print_cpu_model_list_entry, NULL);
Expand All @@ -411,14 +412,14 @@ void s390_cpu_list(void)
for (feat = 0; feat < S390_FEAT_MAX; feat++) {
const S390FeatDef *def = s390_feat_def(feat);

qemu_printf("%-20s %s\n", def->name, def->desc);
qemu_printf(" %-20s %s\n", def->name, def->desc);
}

qemu_printf("\nRecognized feature groups:\n");
for (group = 0; group < S390_FEAT_GROUP_MAX; group++) {
const S390FeatGroupDef *def = s390_feat_group_def(group);

qemu_printf("%-20s %s\n", def->name, def->desc);
qemu_printf(" %-20s %s\n", def->name, def->desc);
}
}

Expand Down

0 comments on commit 7febce3

Please sign in to comment.