Skip to content

Commit

Permalink
s390x/mmu: Remove duplicate check for MMU_DATA_STORE
Browse files Browse the repository at this point in the history
No need to double-check if we have a write.

Found by Coverity (CID: 1406404).

Fixes: 31b5941 ("target/s390x: Return exception from mmu_translate_real")
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191017121922.18840-1-david@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
  • Loading branch information
davidhildenbrand authored and cohuck committed Oct 21, 2019
1 parent be39110 commit 8064af6
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions target/s390x/mmu_helper.c
Expand Up @@ -556,9 +556,7 @@ int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw,
*flags |= PAGE_WRITE_INV;
if (is_low_address(raddr) && rw == MMU_DATA_STORE) {
/* LAP sets bit 56 */
*tec = (raddr & TARGET_PAGE_MASK)
| (rw == MMU_DATA_STORE ? FS_WRITE : FS_READ)
| 0x80;
*tec = (raddr & TARGET_PAGE_MASK) | FS_WRITE | 0x80;
return PGM_PROTECTION;
}
}
Expand Down

0 comments on commit 8064af6

Please sign in to comment.