Skip to content

Commit

Permalink
iotests/283: Use consistent size for source and target
Browse files Browse the repository at this point in the history
The test case forgot to specify the null-co size for the target node.
When adding a check to backup that both sizes match, this would fail
because of the size mismatch and not the behaviour that the test really
wanted to test.

Fixes: a541fcc
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200430142755.315494-2-kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
kevmw committed May 8, 2020
1 parent c1eafd2 commit 813cc25
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion tests/qemu-iotests/283
Expand Up @@ -74,7 +74,11 @@ to check that crash is fixed :)
vm = iotests.VM()
vm.launch()

vm.qmp_log('blockdev-add', **{'node-name': 'target', 'driver': 'null-co'})
vm.qmp_log('blockdev-add', **{
'node-name': 'target',
'driver': 'null-co',
'size': size,
})

vm.qmp_log('blockdev-add', **{
'node-name': 'source',
Expand Down
2 changes: 1 addition & 1 deletion tests/qemu-iotests/283.out
@@ -1,4 +1,4 @@
{"execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name": "target"}}
{"execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name": "target", "size": 1048576}}
{"return": {}}
{"execute": "blockdev-add", "arguments": {"driver": "blkdebug", "image": {"driver": "null-co", "node-name": "base", "size": 1048576}, "node-name": "source"}}
{"return": {}}
Expand Down

0 comments on commit 813cc25

Please sign in to comment.