Skip to content

Commit

Permalink
s390/sclp: fix SCLP facility map
Browse files Browse the repository at this point in the history
Qemu's SCLP implementation incorrectly reports that it supports CPU
reconfiguration. If a guest issues a CPU reconfiguration request it
is rejected as invalid command.

Fix the SCLP_HAS_CPU_INFO mask, and remove the unused
SCLP_CMDW_CONFIGURE_CPU and SCLP_CMDW_DECONFIGURE_CPU defines.

Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Message-ID: <20231024100703.929679-1-hca@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
hcahca authored and huth committed Nov 7, 2023
1 parent 645198d commit 81f9938
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions include/hw/s390x/sclp.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,8 @@
#define MAX_STORAGE_INCREMENTS 1020

/* CPU hotplug SCLP codes */
#define SCLP_HAS_CPU_INFO 0x0C00000000000000ULL
#define SCLP_HAS_CPU_INFO 0x0800000000000000ULL
#define SCLP_CMDW_READ_CPU_INFO 0x00010001
#define SCLP_CMDW_CONFIGURE_CPU 0x00110001
#define SCLP_CMDW_DECONFIGURE_CPU 0x00100001

/* SCLP PCI codes */
#define SCLP_HAS_IOA_RECONFIG 0x0000000040000000ULL
Expand Down

0 comments on commit 81f9938

Please sign in to comment.