Skip to content

Commit

Permalink
bsd-user: Implement umask(2), setlogin(2) and getlogin(2)
Browse files Browse the repository at this point in the history
Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20230925182425.3163-13-kariem.taha2.7@gmail.com>
  • Loading branch information
staceyson authored and bsdimp committed Oct 3, 2023
1 parent a478416 commit 82fe5f3
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 0 deletions.
39 changes: 39 additions & 0 deletions bsd-user/bsd-proc.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "gdbstub/syscalls.h"
#include "qemu/plugin.h"

extern int _getlogin(char*, int);
int bsd_get_ncpu(void);

/* exit(2) */
Expand Down Expand Up @@ -85,4 +86,42 @@ static inline abi_long do_bsd_setgroups(abi_long gidsetsize, abi_long arg2)
return get_errno(setgroups(gidsetsize, grouplist));
}

/* umask(2) */
static inline abi_long do_bsd_umask(abi_long arg1)
{
return get_errno(umask(arg1));
}

/* setlogin(2) */
static inline abi_long do_bsd_setlogin(abi_long arg1)
{
abi_long ret;
void *p;

p = lock_user_string(arg1);
if (p == NULL) {
return -TARGET_EFAULT;
}
ret = get_errno(setlogin(p));
unlock_user(p, arg1, 0);

return ret;
}

/* getlogin(2) */
static inline abi_long do_bsd_getlogin(abi_long arg1, abi_long arg2)
{
abi_long ret;
void *p;

p = lock_user(VERIFY_WRITE, arg1, arg2, 0);
if (p == NULL) {
return -TARGET_EFAULT;
}
ret = get_errno(_getlogin(p, arg2));
unlock_user(p, arg1, arg2);

return ret;
}

#endif /* !BSD_PROC_H_ */
12 changes: 12 additions & 0 deletions bsd-user/freebsd/os-syscall.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,18 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
ret = do_bsd_setgroups(arg1, arg2);
break;

case TARGET_FREEBSD_NR_umask: /* umask(2) */
ret = do_bsd_umask(arg1);
break;

case TARGET_FREEBSD_NR_setlogin: /* setlogin(2) */
ret = do_bsd_setlogin(arg1);
break;

case TARGET_FREEBSD_NR_getlogin: /* getlogin(2) */
ret = do_bsd_getlogin(arg1, arg2);
break;


/*
* File system calls.
Expand Down

0 comments on commit 82fe5f3

Please sign in to comment.