Skip to content

Commit

Permalink
block/rbd: store object_size in BDRVRBDState
Browse files Browse the repository at this point in the history
Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Message-Id: <20210702172356.11574-3-idryomov@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
plieven authored and kevmw committed Jul 9, 2021
1 parent 48672ac commit 832a93d
Showing 1 changed file with 7 additions and 11 deletions.
18 changes: 7 additions & 11 deletions block/rbd.c
Expand Up @@ -102,6 +102,7 @@ typedef struct BDRVRBDState {
char *snap;
char *namespace;
uint64_t image_size;
uint64_t object_size;
} BDRVRBDState;

static int qemu_rbd_connect(rados_t *cluster, rados_ioctx_t *io_ctx,
Expand Down Expand Up @@ -958,6 +959,7 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags,
const QDictEntry *e;
Error *local_err = NULL;
char *keypairs, *secretid;
rbd_image_info_t info;
int r;

keypairs = g_strdup(qdict_get_try_str(options, "=keyvalue-pairs"));
Expand Down Expand Up @@ -1035,12 +1037,14 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags,
#endif
}

r = rbd_get_size(s->image, &s->image_size);
r = rbd_stat(s->image, &info, sizeof(info));
if (r < 0) {
error_setg_errno(errp, -r, "error getting image size from %s",
error_setg_errno(errp, -r, "error getting image info from %s",
s->image_name);
goto failed_post_open;
}
s->image_size = info.size;
s->object_size = info.obj_size;

/* If we are using an rbd snapshot, we must be r/o, otherwise
* leave as-is */
Expand Down Expand Up @@ -1253,15 +1257,7 @@ static BlockAIOCB *qemu_rbd_aio_flush(BlockDriverState *bs,
static int qemu_rbd_getinfo(BlockDriverState *bs, BlockDriverInfo *bdi)
{
BDRVRBDState *s = bs->opaque;
rbd_image_info_t info;
int r;

r = rbd_stat(s->image, &info, sizeof(info));
if (r < 0) {
return r;
}

bdi->cluster_size = info.obj_size;
bdi->cluster_size = s->object_size;
return 0;
}

Expand Down

0 comments on commit 832a93d

Please sign in to comment.