Skip to content

Commit

Permalink
9pfs: local: Fix possible memory leak in local_link()
Browse files Browse the repository at this point in the history
There is a possible memory leak while local_link return -1 without free
odirpath and oname.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Jaijun Chen <chenjiajun8@huawei.com>
Signed-off-by: Xiang Zheng <zhengxiang9@huawei.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
  • Loading branch information
Jiajun Chen authored and gkurz committed Jan 20, 2020
1 parent 43d1455 commit 841b8d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/9pfs/9p-local.c
Expand Up @@ -947,7 +947,7 @@ static int local_link(FsContext *ctx, V9fsPath *oldpath,
if (ctx->export_flags & V9FS_SM_MAPPED_FILE &&
local_is_mapped_file_metadata(ctx, name)) {
errno = EINVAL;
return -1;
goto out;
}

odirfd = local_opendir_nofollow(ctx, odirpath);
Expand Down

0 comments on commit 841b8d0

Please sign in to comment.