Skip to content

Commit

Permalink
target-arm: Remove THUMB2EE feature from AArch64 'any' CPU
Browse files Browse the repository at this point in the history
The AArch64 usermode 'any' CPU type was accidentally specified
with the ARM_FEATURE_THUMB2EE bit set. This is incorrect since
ARMv8 removes Thumb2EE completely. Since we never implemented
Thumb2EE anyway having the feature bit set was fairly harmless
for user-mode, but the correct thing is to not set it at all.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
  • Loading branch information
pm215 committed Apr 17, 2014
1 parent 1090b9c commit 85acfa9
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion target-arm/cpu64.c
Expand Up @@ -83,7 +83,6 @@ static void aarch64_any_initfn(Object *obj)
set_feature(&cpu->env, ARM_FEATURE_VFP4);
set_feature(&cpu->env, ARM_FEATURE_VFP_FP16);
set_feature(&cpu->env, ARM_FEATURE_NEON);
set_feature(&cpu->env, ARM_FEATURE_THUMB2EE);
set_feature(&cpu->env, ARM_FEATURE_ARM_DIV);
set_feature(&cpu->env, ARM_FEATURE_V7MP);
set_feature(&cpu->env, ARM_FEATURE_AARCH64);
Expand Down

0 comments on commit 85acfa9

Please sign in to comment.