Skip to content

Commit

Permalink
target-*: Don't redefine cpu_exec()
Browse files Browse the repository at this point in the history
This function needs to be converted to QOM hook and virtualised for
multi-arch. This rename interferes, as cpu-qom will not have access
to the renaming causing name divergence. This rename doesn't really do
anything anyway so just delete it.

Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Message-Id: <69bd25a8678b8b31b91cd9760c777bed1aafb44e.1437212383.git.crosthwaite.peter@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Crosthwaite <crosthwaitepeter@gmail.com>
  • Loading branch information
pcrost authored and bonzini committed Jun 29, 2016
1 parent be968c7 commit 8642c1b
Show file tree
Hide file tree
Showing 20 changed files with 18 additions and 53 deletions.
2 changes: 2 additions & 0 deletions include/exec/cpu-all.h
Expand Up @@ -304,4 +304,6 @@ void dump_opcount_info(FILE *f, fprintf_function cpu_fprintf);
int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr,
uint8_t *buf, int len, int is_write);

int cpu_exec(CPUState *cpu);

#endif /* CPU_ALL_H */
32 changes: 16 additions & 16 deletions linux-user/main.c
Expand Up @@ -157,7 +157,7 @@ static inline void exclusive_idle(void)
}

/* Start an exclusive operation.
Must only be called from outside cpu_arm_exec. */
Must only be called from outside cpu_exec. */
static inline void start_exclusive(void)
{
CPUState *other_cpu;
Expand Down Expand Up @@ -291,7 +291,7 @@ void cpu_loop(CPUX86State *env)

for(;;) {
cpu_exec_start(cs);
trapnr = cpu_x86_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch(trapnr) {
case 0x80:
Expand Down Expand Up @@ -732,7 +732,7 @@ void cpu_loop(CPUARMState *env)

for(;;) {
cpu_exec_start(cs);
trapnr = cpu_arm_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch(trapnr) {
case EXCP_UDEF:
Expand Down Expand Up @@ -1068,7 +1068,7 @@ void cpu_loop(CPUARMState *env)

for (;;) {
cpu_exec_start(cs);
trapnr = cpu_arm_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);

switch (trapnr) {
Expand Down Expand Up @@ -1156,7 +1156,7 @@ void cpu_loop(CPUUniCore32State *env)

for (;;) {
cpu_exec_start(cs);
trapnr = uc32_cpu_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch (trapnr) {
case UC32_EXCP_PRIV:
Expand Down Expand Up @@ -1361,7 +1361,7 @@ void cpu_loop (CPUSPARCState *env)

while (1) {
cpu_exec_start(cs);
trapnr = cpu_sparc_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);

/* Compute PSR before exposing state. */
Expand Down Expand Up @@ -1633,7 +1633,7 @@ void cpu_loop(CPUPPCState *env)

for(;;) {
cpu_exec_start(cs);
trapnr = cpu_ppc_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch(trapnr) {
case POWERPC_EXCP_NONE:
Expand Down Expand Up @@ -2490,7 +2490,7 @@ void cpu_loop(CPUMIPSState *env)

for(;;) {
cpu_exec_start(cs);
trapnr = cpu_mips_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch(trapnr) {
case EXCP_SYSCALL:
Expand Down Expand Up @@ -2730,7 +2730,7 @@ void cpu_loop(CPUOpenRISCState *env)

for (;;) {
cpu_exec_start(cs);
trapnr = cpu_openrisc_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
gdbsig = 0;

Expand Down Expand Up @@ -2824,7 +2824,7 @@ void cpu_loop(CPUSH4State *env)

while (1) {
cpu_exec_start(cs);
trapnr = cpu_sh4_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);

switch (trapnr) {
Expand Down Expand Up @@ -2890,7 +2890,7 @@ void cpu_loop(CPUCRISState *env)

while (1) {
cpu_exec_start(cs);
trapnr = cpu_cris_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch (trapnr) {
case 0xaa:
Expand Down Expand Up @@ -2955,7 +2955,7 @@ void cpu_loop(CPUMBState *env)

while (1) {
cpu_exec_start(cs);
trapnr = cpu_mb_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch (trapnr) {
case 0xaa:
Expand Down Expand Up @@ -3072,7 +3072,7 @@ void cpu_loop(CPUM68KState *env)

for(;;) {
cpu_exec_start(cs);
trapnr = cpu_m68k_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch(trapnr) {
case EXCP_ILLEGAL:
Expand Down Expand Up @@ -3215,7 +3215,7 @@ void cpu_loop(CPUAlphaState *env)

while (1) {
cpu_exec_start(cs);
trapnr = cpu_alpha_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);

/* All of the traps imply a transition through PALcode, which
Expand Down Expand Up @@ -3407,7 +3407,7 @@ void cpu_loop(CPUS390XState *env)

while (1) {
cpu_exec_start(cs);
trapnr = cpu_s390x_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch (trapnr) {
case EXCP_INTERRUPT:
Expand Down Expand Up @@ -3716,7 +3716,7 @@ void cpu_loop(CPUTLGState *env)

while (1) {
cpu_exec_start(cs);
trapnr = cpu_tilegx_exec(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
switch (trapnr) {
case TILEGX_EXCP_SYSCALL:
Expand Down
2 changes: 0 additions & 2 deletions target-alpha/cpu.h
Expand Up @@ -326,7 +326,6 @@ void alpha_cpu_do_unaligned_access(CPUState *cpu, vaddr addr,
int is_write, int is_user, uintptr_t retaddr);

#define cpu_list alpha_cpu_list
#define cpu_exec cpu_alpha_exec
#define cpu_signal_handler cpu_alpha_signal_handler

#include "exec/cpu-all.h"
Expand Down Expand Up @@ -467,7 +466,6 @@ AlphaCPU *cpu_alpha_init(const char *cpu_model);
#define cpu_init(cpu_model) CPU(cpu_alpha_init(cpu_model))

void alpha_cpu_list(FILE *f, fprintf_function cpu_fprintf);
int cpu_alpha_exec(CPUState *cpu);
/* you can call this signal handler from your SIGBUS and SIGSEGV
signal handlers to inform the virtual CPU of exceptions. non zero
is returned if the signal was handled by the virtual CPU. */
Expand Down
2 changes: 0 additions & 2 deletions target-arm/cpu.h
Expand Up @@ -703,7 +703,6 @@ int aarch64_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);
#endif

ARMCPU *cpu_arm_init(const char *cpu_model);
int cpu_arm_exec(CPUState *cpu);
target_ulong do_arm_semihosting(CPUARMState *env);
void aarch64_sync_32_to_64(CPUARMState *env);
void aarch64_sync_64_to_32(CPUARMState *env);
Expand Down Expand Up @@ -1891,7 +1890,6 @@ static inline bool arm_excp_unmasked(CPUState *cs, unsigned int excp_idx,

#define cpu_init(cpu_model) CPU(cpu_arm_init(cpu_model))

#define cpu_exec cpu_arm_exec
#define cpu_signal_handler cpu_arm_signal_handler
#define cpu_list arm_cpu_list

Expand Down
2 changes: 0 additions & 2 deletions target-cris/cpu.h
Expand Up @@ -213,7 +213,6 @@ int cris_cpu_gdb_read_register(CPUState *cpu, uint8_t *buf, int reg);
int cris_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);

CRISCPU *cpu_cris_init(const char *cpu_model);
int cpu_cris_exec(CPUState *cpu);
/* you can call this signal handler from your SIGBUS and SIGSEGV
signal handlers to inform the virtual CPU of exceptions. non zero
is returned if the signal was handled by the virtual CPU. */
Expand Down Expand Up @@ -260,7 +259,6 @@ enum {

#define cpu_init(cpu_model) CPU(cpu_cris_init(cpu_model))

#define cpu_exec cpu_cris_exec
#define cpu_signal_handler cpu_cris_signal_handler

/* MMU modes definitions */
Expand Down
2 changes: 0 additions & 2 deletions target-i386/cpu.h
Expand Up @@ -1235,7 +1235,6 @@ void x86_cpu_exec_exit(CPUState *cpu);

X86CPU *cpu_x86_init(const char *cpu_model);
X86CPU *cpu_x86_create(const char *cpu_model, Error **errp);
int cpu_x86_exec(CPUState *cpu);
void x86_cpu_list(FILE *f, fprintf_function cpu_fprintf);
int cpu_x86_support_mca_broadcast(CPUX86State *env);

Expand Down Expand Up @@ -1411,7 +1410,6 @@ uint64_t cpu_get_tsc(CPUX86State *env);

#define cpu_init(cpu_model) CPU(cpu_x86_init(cpu_model))

#define cpu_exec cpu_x86_exec
#define cpu_signal_handler cpu_x86_signal_handler
#define cpu_list x86_cpu_list

Expand Down
2 changes: 0 additions & 2 deletions target-lm32/cpu.h
Expand Up @@ -236,7 +236,6 @@ static inline lm32_wp_t lm32_wp_type(uint32_t dc, int idx)
}

LM32CPU *cpu_lm32_init(const char *cpu_model);
int cpu_lm32_exec(CPUState *cpu);
/* you can call this signal handler from your SIGBUS and SIGSEGV
signal handlers to inform the virtual CPU of exceptions. non zero
is returned if the signal was handled by the virtual CPU. */
Expand All @@ -257,7 +256,6 @@ bool lm32_cpu_do_semihosting(CPUState *cs);
#define cpu_init(cpu_model) CPU(cpu_lm32_init(cpu_model))

#define cpu_list lm32_cpu_list
#define cpu_exec cpu_lm32_exec
#define cpu_signal_handler cpu_lm32_signal_handler

int lm32_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int rw,
Expand Down
2 changes: 0 additions & 2 deletions target-m68k/cpu.h
Expand Up @@ -146,7 +146,6 @@ void m68k_cpu_exec_exit(CPUState *cs);
void m68k_tcg_init(void);
void m68k_cpu_init_gdb(M68kCPU *cpu);
M68kCPU *cpu_m68k_init(const char *cpu_model);
int cpu_m68k_exec(CPUState *cpu);
/* you can call this signal handler from your SIGBUS and SIGSEGV
signal handlers to inform the virtual CPU of exceptions. non zero
is returned if the signal was handled by the virtual CPU. */
Expand Down Expand Up @@ -243,7 +242,6 @@ void register_m68k_insns (CPUM68KState *env);

#define cpu_init(cpu_model) CPU(cpu_m68k_init(cpu_model))

#define cpu_exec cpu_m68k_exec
#define cpu_signal_handler cpu_m68k_signal_handler
#define cpu_list m68k_cpu_list

Expand Down
2 changes: 0 additions & 2 deletions target-microblaze/cpu.h
Expand Up @@ -321,7 +321,6 @@ int mb_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);

void mb_tcg_init(void);
MicroBlazeCPU *cpu_mb_init(const char *cpu_model);
int cpu_mb_exec(CPUState *cpu);
/* you can call this signal handler from your SIGBUS and SIGSEGV
signal handlers to inform the virtual CPU of exceptions. non zero
is returned if the signal was handled by the virtual CPU. */
Expand All @@ -336,7 +335,6 @@ int cpu_mb_signal_handler(int host_signum, void *pinfo,

#define cpu_init(cpu_model) CPU(cpu_mb_init(cpu_model))

#define cpu_exec cpu_mb_exec
#define cpu_signal_handler cpu_mb_signal_handler

/* MMU modes definitions */
Expand Down
2 changes: 0 additions & 2 deletions target-mips/cpu.h
Expand Up @@ -674,7 +674,6 @@ void mips_cpu_unassigned_access(CPUState *cpu, hwaddr addr,

void mips_cpu_list (FILE *f, fprintf_function cpu_fprintf);

#define cpu_exec cpu_mips_exec
#define cpu_signal_handler cpu_mips_signal_handler
#define cpu_list mips_cpu_list

Expand Down Expand Up @@ -800,7 +799,6 @@ enum {
*/
#define CPU_INTERRUPT_WAKE CPU_INTERRUPT_TGT_INT_0

int cpu_mips_exec(CPUState *cpu);
void mips_tcg_init(void);
MIPSCPU *cpu_mips_init(const char *cpu_model);
int cpu_mips_signal_handler(int host_signum, void *pinfo, void *puc);
Expand Down
2 changes: 0 additions & 2 deletions target-moxie/cpu.h
Expand Up @@ -109,7 +109,6 @@ static inline MoxieCPU *moxie_env_get_cpu(CPUMoxieState *env)
#define ENV_OFFSET offsetof(MoxieCPU, env)

MoxieCPU *cpu_moxie_init(const char *cpu_model);
int cpu_moxie_exec(CPUState *cpu);
void moxie_cpu_do_interrupt(CPUState *cs);
void moxie_cpu_dump_state(CPUState *cpu, FILE *f,
fprintf_function cpu_fprintf, int flags);
Expand All @@ -120,7 +119,6 @@ int cpu_moxie_signal_handler(int host_signum, void *pinfo,

#define cpu_init(cpu_model) CPU(cpu_moxie_init(cpu_model))

#define cpu_exec cpu_moxie_exec
#define cpu_signal_handler cpu_moxie_signal_handler

static inline int cpu_mmu_index(CPUMoxieState *env, bool ifetch)
Expand Down
2 changes: 0 additions & 2 deletions target-openrisc/cpu.h
Expand Up @@ -344,7 +344,6 @@ static inline OpenRISCCPU *openrisc_env_get_cpu(CPUOpenRISCState *env)
OpenRISCCPU *cpu_openrisc_init(const char *cpu_model);

void cpu_openrisc_list(FILE *f, fprintf_function cpu_fprintf);
int cpu_openrisc_exec(CPUState *cpu);
void openrisc_cpu_do_interrupt(CPUState *cpu);
bool openrisc_cpu_exec_interrupt(CPUState *cpu, int int_req);
void openrisc_cpu_dump_state(CPUState *cpu, FILE *f,
Expand All @@ -358,7 +357,6 @@ int openrisc_cpu_handle_mmu_fault(CPUState *cpu, vaddr address,
int cpu_openrisc_signal_handler(int host_signum, void *pinfo, void *puc);

#define cpu_list cpu_openrisc_list
#define cpu_exec cpu_openrisc_exec
#define cpu_signal_handler cpu_openrisc_signal_handler

#ifndef CONFIG_USER_ONLY
Expand Down
2 changes: 0 additions & 2 deletions target-ppc/cpu.h
Expand Up @@ -1189,7 +1189,6 @@ extern const struct VMStateDescription vmstate_ppc_cpu;
PowerPCCPU *cpu_ppc_init(const char *cpu_model);
void ppc_translate_init(void);
void gen_update_current_nip(void *opaque);
int cpu_ppc_exec (CPUState *s);
/* you can call this signal handler from your SIGBUS and SIGSEGV
signal handlers to inform the virtual CPU of exceptions. non zero
is returned if the signal was handled by the virtual CPU. */
Expand Down Expand Up @@ -1268,7 +1267,6 @@ int ppc_dcr_write (ppc_dcr_t *dcr_env, int dcrn, uint32_t val);

#define cpu_init(cpu_model) CPU(cpu_ppc_init(cpu_model))

#define cpu_exec cpu_ppc_exec
#define cpu_signal_handler cpu_ppc_signal_handler
#define cpu_list ppc_cpu_list

Expand Down
2 changes: 0 additions & 2 deletions target-s390x/cpu.h
Expand Up @@ -463,7 +463,6 @@ S390CPU *cpu_s390x_init(const char *cpu_model);
S390CPU *s390x_new_cpu(const char *cpu_model, int64_t id, Error **errp);
S390CPU *cpu_s390x_create(const char *cpu_model, Error **errp);
void s390x_translate_init(void);
int cpu_s390x_exec(CPUState *cpu);

/* you can call this signal handler from your SIGBUS and SIGSEGV
signal handlers to inform the virtual CPU of exceptions. non zero
Expand Down Expand Up @@ -627,7 +626,6 @@ void cpu_unlock(void);
extern void subsystem_reset(void);

#define cpu_init(model) CPU(cpu_s390x_init(model))
#define cpu_exec cpu_s390x_exec
#define cpu_signal_handler cpu_s390x_signal_handler

void s390_cpu_list(FILE *f, fprintf_function cpu_fprintf);
Expand Down
2 changes: 0 additions & 2 deletions target-sh4/cpu.h
Expand Up @@ -221,7 +221,6 @@ int superh_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);

void sh4_translate_init(void);
SuperHCPU *cpu_sh4_init(const char *cpu_model);
int cpu_sh4_exec(CPUState *s);
int cpu_sh4_signal_handler(int host_signum, void *pinfo,
void *puc);
int superh_cpu_handle_mmu_fault(CPUState *cpu, vaddr address, int rw,
Expand Down Expand Up @@ -254,7 +253,6 @@ void cpu_load_tlb(CPUSH4State * env);

#define cpu_init(cpu_model) CPU(cpu_sh4_init(cpu_model))

#define cpu_exec cpu_sh4_exec
#define cpu_signal_handler cpu_sh4_signal_handler
#define cpu_list sh4_cpu_list

Expand Down
2 changes: 0 additions & 2 deletions target-sparc/cpu.h
Expand Up @@ -565,7 +565,6 @@ int sparc_cpu_memory_rw_debug(CPUState *cpu, vaddr addr,
void gen_intermediate_code_init(CPUSPARCState *env);

/* cpu-exec.c */
int cpu_sparc_exec(CPUState *cpu);

/* win_helper.c */
target_ulong cpu_get_psr(CPUSPARCState *env1);
Expand Down Expand Up @@ -626,7 +625,6 @@ int cpu_sparc_signal_handler(int host_signum, void *pinfo, void *puc);
#define cpu_init(cpu_model) CPU(cpu_sparc_init(cpu_model))
#endif

#define cpu_exec cpu_sparc_exec
#define cpu_signal_handler cpu_sparc_signal_handler
#define cpu_list sparc_cpu_list

Expand Down
2 changes: 0 additions & 2 deletions target-tilegx/cpu.h
Expand Up @@ -158,14 +158,12 @@ static inline TileGXCPU *tilegx_env_get_cpu(CPUTLGState *env)
#include "exec/cpu-all.h"

void tilegx_tcg_init(void);
int cpu_tilegx_exec(CPUState *s);
int cpu_tilegx_signal_handler(int host_signum, void *pinfo, void *puc);

TileGXCPU *cpu_tilegx_init(const char *cpu_model);

#define cpu_init(cpu_model) CPU(cpu_tilegx_init(cpu_model))

#define cpu_exec cpu_tilegx_exec
#define cpu_signal_handler cpu_tilegx_signal_handler

static inline void cpu_get_tb_cpu_state(CPUTLGState *env, target_ulong *pc,
Expand Down

0 comments on commit 8642c1b

Please sign in to comment.