Skip to content

Commit

Permalink
slirp: goto bad in udp_input if sosendto fails
Browse files Browse the repository at this point in the history
Before this patch, if sosendto fails, udp_input is executed as if the
packet was sent, recording the packet for icmp errors, which does not
makes sense since the packet was not actually sent, errors would be
related to a previous packet.

This patch adds a goto bad to cut the execution of this function.

Signed-off-by: Guillaume Subiron <maethor@subiron.org>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
  • Loading branch information
Guillaume Subiron authored and jasowang committed Feb 4, 2016
1 parent d7f0536 commit 86c9e1e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions slirp/udp.c
Expand Up @@ -218,6 +218,7 @@ udp_input(register struct mbuf *m, int iphlen)
*ip=save_ip;
DEBUG_MISC((dfd,"udp tx errno = %d-%s\n",errno,strerror(errno)));
icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));
goto bad;
}

m_free(so->so_m); /* used for ICMP if error on sorecvfrom */
Expand Down

0 comments on commit 86c9e1e

Please sign in to comment.