Skip to content

Commit

Permalink
migration/multifd: Drop stale comment for multifd zero copy
Browse files Browse the repository at this point in the history
We've already done that with multifd_flush_after_each_section, for multifd
in general.  Drop the stale "TODO-like" comment.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240202102857.110210-2-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
  • Loading branch information
xzpeter committed Feb 5, 2024
1 parent 06152b8 commit 8888a55
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions migration/multifd.c
Original file line number Diff line number Diff line change
Expand Up @@ -598,17 +598,6 @@ int multifd_send_sync_main(void)
}
}

/*
* When using zero-copy, it's necessary to flush the pages before any of
* the pages can be sent again, so we'll make sure the new version of the
* pages will always arrive _later_ than the old pages.
*
* Currently we achieve this by flushing the zero-page requested writes
* per ram iteration, but in the future we could potentially optimize it
* to be less frequent, e.g. only after we finished one whole scanning of
* all the dirty bitmaps.
*/

flush_zero_copy = migrate_zero_copy_send();

for (i = 0; i < migrate_multifd_channels(); i++) {
Expand Down

0 comments on commit 8888a55

Please sign in to comment.