Skip to content

Commit

Permalink
Fix broken configure with -Wunused-parameter
Browse files Browse the repository at this point in the history
The configure script fails because it tries to compile small C programs
with a main function which is declared with arguments argc and argv
although those arguments are unused.

Running `configure -extra-cflags=-Wunused-parameter` triggers the problem.
configure for a native build does abort but shows the error in config.log.
A cross build configure for Windows with Debian stable aborts with an
error.

Avoiding unused arguments fixes this.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20221102202258.456359-1-sw@weilnetz.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
stweil authored and bonzini committed Nov 6, 2022
1 parent 75ac231 commit 8a0afbb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions configure
Expand Up @@ -1258,7 +1258,7 @@ if test "$stack_protector" != "no"; then
cat > $TMPC << EOF
int main(int argc, char *argv[])
{
char arr[64], *p = arr, *c = argv[0];
char arr[64], *p = arr, *c = argv[argc - 1];
while (*c) {
*p++ = *c++;
}
Expand Down Expand Up @@ -1607,7 +1607,7 @@ fi

if test "$safe_stack" = "yes"; then
cat > $TMPC << EOF
int main(int argc, char *argv[])
int main(void)
{
#if ! __has_feature(safe_stack)
#error SafeStack Disabled
Expand All @@ -1629,7 +1629,7 @@ EOF
fi
else
cat > $TMPC << EOF
int main(int argc, char *argv[])
int main(void)
{
#if defined(__has_feature)
#if __has_feature(safe_stack)
Expand Down Expand Up @@ -1675,7 +1675,7 @@ static const int Z = 1;
#define TAUT(X) ((X) == Z)
#define PAREN(X, Y) (X == Y)
#define ID(X) (X)
int main(int argc, char *argv[])
int main(void)
{
int x = 0, y = 0;
x = ID(x);
Expand Down

0 comments on commit 8a0afbb

Please sign in to comment.