Skip to content

Commit

Permalink
change CPUArchId.cpu type to Object*
Browse files Browse the repository at this point in the history
so it could be reused for SPAPR cores as well

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
  • Loading branch information
Igor Mammedov authored and dgibson committed Feb 22, 2017
1 parent 1ea69c0 commit 8aba384
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion hw/acpi/cpu.c
Expand Up @@ -198,7 +198,7 @@ void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner,
state->dev_count = id_list->len;
state->devs = g_new0(typeof(*state->devs), state->dev_count);
for (i = 0; i < id_list->len; i++) {
state->devs[i].cpu = id_list->cpus[i].cpu;
state->devs[i].cpu = CPU(id_list->cpus[i].cpu);
state->devs[i].arch_id = id_list->cpus[i].arch_id;
}
memory_region_init_io(&state->ctrl_reg, owner, &cpu_hotplug_ops, state,
Expand Down
8 changes: 4 additions & 4 deletions hw/i386/pc.c
Expand Up @@ -1830,7 +1830,7 @@ static void pc_cpu_plug(HotplugHandler *hotplug_dev,
}

found_cpu = pc_find_cpu_slot(MACHINE(pcms), cpu->apic_id, NULL);
found_cpu->cpu = CPU(dev);
found_cpu->cpu = OBJECT(dev);
out:
error_propagate(errp, local_err);
}
Expand Down Expand Up @@ -2288,13 +2288,13 @@ static const CPUArchIdList *pc_possible_cpu_arch_ids(MachineState *ms)
static HotpluggableCPUList *pc_query_hotpluggable_cpus(MachineState *machine)
{
int i;
CPUState *cpu;
Object *cpu;
HotpluggableCPUList *head = NULL;
const char *cpu_type;

cpu = machine->possible_cpus->cpus[0].cpu;
assert(cpu); /* BSP is always present */
cpu_type = object_class_get_name(OBJECT_CLASS(CPU_GET_CLASS(cpu)));
cpu_type = object_get_typename(cpu);

for (i = 0; i < machine->possible_cpus->len; i++) {
HotpluggableCPUList *list_item = g_new0(typeof(*list_item), 1);
Expand All @@ -2308,7 +2308,7 @@ static HotpluggableCPUList *pc_query_hotpluggable_cpus(MachineState *machine)
cpu = machine->possible_cpus->cpus[i].cpu;
if (cpu) {
cpu_item->has_qom_path = true;
cpu_item->qom_path = object_get_canonical_path(OBJECT(cpu));
cpu_item->qom_path = object_get_canonical_path(cpu);
}

list_item->value = cpu_item;
Expand Down
2 changes: 1 addition & 1 deletion include/hw/boards.h
Expand Up @@ -51,7 +51,7 @@ void machine_register_compat_props(MachineState *machine);
typedef struct {
uint64_t arch_id;
CpuInstanceProperties props;
struct CPUState *cpu;
Object *cpu;
} CPUArchId;

/**
Expand Down

0 comments on commit 8aba384

Please sign in to comment.