Skip to content

Commit

Permalink
qapi: Move @string out of common.json to discourage reuse
Browse files Browse the repository at this point in the history
Use of String is problematic, because it results in awkward interface
documentation.  The previous commit cleaned up one instance.

Move String out of common.json next to its remaining users in net.json
to discourage reuse elsewhere.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240205074709.3613229-15-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
  • Loading branch information
Markus Armbruster committed Feb 12, 2024
1 parent 4edb196 commit 8bf6954
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 13 deletions.
2 changes: 1 addition & 1 deletion include/net/filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#ifndef QEMU_NET_FILTER_H
#define QEMU_NET_FILTER_H

#include "qapi/qapi-types-net.h"
#include "qapi/qapi-types-common.h"
#include "qemu/queue.h"
#include "qom/object.h"
#include "net/queue.h"
Expand Down
11 changes: 0 additions & 11 deletions qapi/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,6 @@
{ 'enum': 'OnOffSplit',
'data': [ 'on', 'off', 'split' ] }

##
# @String:
#
# A fat type wrapping 'str', to be embedded in lists.
#
# Since: 1.2
##
{ 'struct': 'String',
'data': {
'str': 'str' } }

##
# @StrOrNull:
#
Expand Down
12 changes: 11 additions & 1 deletion qapi/net.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
# = Net devices
##

{ 'include': 'common.json' }
{ 'include': 'sockets.json' }

##
Expand Down Expand Up @@ -105,6 +104,17 @@
'*addr': 'str',
'*vectors': 'uint32' } }

##
# @String:
#
# A fat type wrapping 'str', to be embedded in lists.
#
# Since: 1.2
##
{ 'struct': 'String',
'data': {
'str': 'str' } }

##
# @NetdevUserOptions:
#
Expand Down

0 comments on commit 8bf6954

Please sign in to comment.