Skip to content

Commit

Permalink
target/mips: Convert Rel6 COP1X opcode to decodetree
Browse files Browse the repository at this point in the history
COP1x opcode has been removed from the Release 6.

Add a single decodetree entry for it, triggering
Reserved Instruction if ever used.

Remove unreachable check_insn_opc_removed() call.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201208203704.243704-8-f4bug@amsat.org>
  • Loading branch information
philmd committed Jan 7, 2021
1 parent 58d8597 commit 8d459fe
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions target/mips/mips32r6.decode
Expand Up @@ -16,4 +16,6 @@

LSA 000000 ..... ..... ..... 000 .. 000101 @lsa

REMOVED 010011 ----- ----- ----- ----- ------ # COP1X (COP3)

REMOVED 011100 ----- ----- ----- ----- ------ # SPECIAL2
1 change: 0 additions & 1 deletion target/mips/translate.c
Expand Up @@ -28827,7 +28827,6 @@ static bool decode_opc_legacy(CPUMIPSState *env, DisasContext *ctx)
break;

case OPC_CP3:
check_insn_opc_removed(ctx, ISA_MIPS_R6);
if (ctx->CP0_Config1 & (1 << CP0C1_FP)) {
check_cp1_enabled(ctx);
op1 = MASK_CP3(ctx->opcode);
Expand Down

0 comments on commit 8d459fe

Please sign in to comment.