Skip to content

Commit

Permalink
checkpatch: tweak the files in which TABs are checked
Browse files Browse the repository at this point in the history
Include Python and shell scripts, and make an exception for Perl
scripts we imported from Linux or elsewhere.

Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
bonzini committed Aug 10, 2016
1 parent 3fdd0ee commit 906fb13
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions scripts/checkpatch.pl
Expand Up @@ -1334,7 +1334,7 @@ sub process {
}

# check we are in a valid source file if not then ignore this hunk
next if ($realfile !~ /\.(h|c|cpp|s|S|pl|sh)$/);
next if ($realfile !~ /\.(h|c|cpp|s|S|pl|py|sh)$/);

#80 column limit
if ($line =~ /^\+/ &&
Expand All @@ -1354,10 +1354,11 @@ sub process {
WARN("adding a line without newline at end of file\n" . $herecurr);
}

# check we are in a valid source file C or perl if not then ignore this hunk
next if ($realfile !~ /\.(h|c|cpp|pl)$/);
# tabs are only allowed in assembly source code, and in
# some scripts we imported from other projects.
next if ($realfile =~ /\.(s|S)$/);
next if ($realfile =~ /(checkpatch|get_maintainer|texi2pod)\.pl$/);

# in QEMU, no tabs are allowed
if ($rawline =~ /^\+.*\t/) {
my $herevet = "$here\n" . cat_vet($rawline) . "\n";
ERROR("code indent should never use tabs\n" . $herevet);
Expand Down

0 comments on commit 906fb13

Please sign in to comment.