Skip to content

Commit

Permalink
hw/block/nvme: factor out block backend setup
Browse files Browse the repository at this point in the history
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Message-Id: <20200609190333.59390-13-its@irrelevant.dk>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
birkelund authored and kevmw committed Jun 17, 2020
1 parent a17f501 commit 90f4511
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions hw/block/nvme.c
Expand Up @@ -1410,6 +1410,13 @@ static void nvme_init_state(NvmeCtrl *n)
n->cq = g_new0(NvmeCQueue *, n->params.max_ioqpairs + 1);
}

static void nvme_init_blk(NvmeCtrl *n, Error **errp)
{
blkconf_blocksizes(&n->conf);
blkconf_apply_backend_options(&n->conf, blk_is_read_only(n->conf.blk),
false, errp);
}

static void nvme_realize(PCIDevice *pci_dev, Error **errp)
{
NvmeCtrl *n = NVME(pci_dev);
Expand All @@ -1434,9 +1441,9 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp)
return;
}

blkconf_blocksizes(&n->conf);
if (!blkconf_apply_backend_options(&n->conf, blk_is_read_only(n->conf.blk),
false, errp)) {
nvme_init_blk(n, &local_err);
if (local_err) {
error_propagate(errp, local_err);
return;
}

Expand Down

0 comments on commit 90f4511

Please sign in to comment.