Skip to content

Commit

Permalink
block/parallels: replace magic constants 4, 64 with proper sizeofs
Browse files Browse the repository at this point in the history
simple purification..

Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Roman Kagan <rkagan@parallels.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Roman Kagan <rkagan@parallels.com>
Message-id: 1430207220-24458-8-git-send-email-den@openvz.org
CC: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  • Loading branch information
Denis V. Lunev authored and stefanhaRH committed May 22, 2015
1 parent 481fb9c commit 912f312
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions block/parallels.c
Expand Up @@ -32,7 +32,6 @@
#define HEADER_MAGIC "WithoutFreeSpace"
#define HEADER_MAGIC2 "WithouFreSpacExt"
#define HEADER_VERSION 2
#define HEADER_SIZE 64

// always little-endian
typedef struct ParallelsHeader {
Expand Down Expand Up @@ -67,7 +66,7 @@ static int parallels_probe(const uint8_t *buf, int buf_size, const char *filenam
{
const ParallelsHeader *ph = (const void *)buf;

if (buf_size < HEADER_SIZE)
if (buf_size < sizeof(ParallelsHeader))
return 0;

if ((!memcmp(ph->magic, HEADER_MAGIC, 16) ||
Expand Down Expand Up @@ -120,7 +119,7 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
}

s->catalog_size = le32_to_cpu(ph.catalog_entries);
if (s->catalog_size > INT_MAX / 4) {
if (s->catalog_size > INT_MAX / sizeof(uint32_t)) {
error_setg(errp, "Catalog too large");
ret = -EFBIG;
goto fail;
Expand All @@ -131,7 +130,8 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
goto fail;
}

ret = bdrv_pread(bs->file, 64, s->catalog_bitmap, s->catalog_size * 4);
ret = bdrv_pread(bs->file, sizeof(ParallelsHeader),
s->catalog_bitmap, s->catalog_size * sizeof(uint32_t));
if (ret < 0) {
goto fail;
}
Expand Down

0 comments on commit 912f312

Please sign in to comment.