Skip to content

Commit

Permalink
qemu-img: abort when full_backing_filename not present
Browse files Browse the repository at this point in the history
...But only if we have the backing_filename. It means something Scary
happened and we can't really be quite exactly sure if we can trust the
backing_filename.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 1450122916-4706-5-git-send-email-jsnow@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
  • Loading branch information
jnsnow authored and XanClic committed Dec 18, 2015
1 parent 5c9d9ca commit 92d617a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion qemu-img.c
Expand Up @@ -2040,7 +2040,10 @@ static ImageInfoList *collect_image_info_list(const char *filename,
if (info->has_full_backing_filename) {
filename = info->full_backing_filename;
} else if (info->has_backing_filename) {
filename = info->backing_filename;
error_report("Could not determine absolute backing filename,"
" but backing filename '%s' present",
info->backing_filename);
goto err;
}
if (info->has_backing_filename_format) {
fmt = info->backing_filename_format;
Expand Down

0 comments on commit 92d617a

Please sign in to comment.