Skip to content

Commit

Permalink
target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT
Browse files Browse the repository at this point in the history
The LDT/STT (load/store unprivileged) instruction decode was using
the wrong MMU index value. This meant that instead of these insns
being "always access as if user-mode regardless of current privilege"
they were "always access as if kernel-mode regardless of current
privilege". This went unnoticed because AArch64 Linux doesn't use
these instructions.

Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Greg Bellows <greg.bellows@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
I'm not counting this as a security issue because I'm assuming
nobody treats TCG guests as a security boundary (certainly I
would not recommend doing so...)
  • Loading branch information
pm215 committed Feb 5, 2015
1 parent 6d54ed3 commit 949013c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion target-arm/translate-a64.c
Expand Up @@ -2107,7 +2107,7 @@ static void disas_ldst_reg_imm9(DisasContext *s, uint32_t insn)
}
} else {
TCGv_i64 tcg_rt = cpu_reg(s, rt);
int memidx = is_unpriv ? 1 : get_mem_index(s);
int memidx = is_unpriv ? MMU_USER_IDX : get_mem_index(s);

if (is_store) {
do_gpr_st_memidx(s, tcg_rt, tcg_addr, size, memidx);
Expand Down

0 comments on commit 949013c

Please sign in to comment.