Skip to content

Commit

Permalink
xen: remove xen_vcpu_init
Browse files Browse the repository at this point in the history
No need for xen_vcpu_init anymore:

- the RTC emulator doesn't have any periodic timers continuously running
even in absence of guest interactions anymore;

- qemu_dummy_start_vcpu takes care of disabling TCG for us, so we don't
need to do it manually here.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
  • Loading branch information
Stefano Stabellini committed Jun 3, 2013
1 parent 9f24a80 commit 95222d0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 25 deletions.
1 change: 0 additions & 1 deletion hw/i386/pc_piix.c
Expand Up @@ -324,7 +324,6 @@ static void pc_xen_hvm_init(QEMUMachineInitArgs *args)
hw_error("xen hardware virtual machine initialisation failed");
}
pc_init_pci_no_kvmclock(args);
xen_vcpu_init();
}
#endif

Expand Down
1 change: 0 additions & 1 deletion include/hw/xen/xen.h
Expand Up @@ -38,7 +38,6 @@ qemu_irq *xen_interrupt_controller_init(void);

int xen_init(void);
int xen_hvm_init(void);
void xen_vcpu_init(void);
void xenstore_store_pv_console_info(int i, struct CharDriverState *chr);

#if defined(NEED_CPU_H) && !defined(CONFIG_USER_ONLY)
Expand Down
23 changes: 0 additions & 23 deletions xen-all.c
Expand Up @@ -574,29 +574,6 @@ void qmp_xen_set_global_dirty_log(bool enable, Error **errp)
}
}

/* VCPU Operations, MMIO, IO ring ... */

static void xen_reset_vcpu(void *opaque)
{
CPUState *cpu = opaque;

cpu->halted = 1;
}

void xen_vcpu_init(void)
{
if (first_cpu != NULL) {
CPUState *cpu = ENV_GET_CPU(first_cpu);

qemu_register_reset(xen_reset_vcpu, cpu);
xen_reset_vcpu(cpu);
}
/* if rtc_clock is left to default (host_clock), disable it */
if (rtc_clock == host_clock) {
qemu_clock_enable(rtc_clock, false);
}
}

/* get the ioreq packets from share mem */
static ioreq_t *cpu_get_ioreq_from_shared_memory(XenIOState *state, int vcpu)
{
Expand Down

0 comments on commit 95222d0

Please sign in to comment.