Skip to content

Commit

Permalink
qemu-img: Fix convert, amend error messages for unknown options
Browse files Browse the repository at this point in the history
Message quality regressed in commit dc523cd.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
Markus Armbruster authored and kevmw committed Mar 16, 2015
1 parent 0c30411 commit 97a2ca7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
6 changes: 2 additions & 4 deletions qemu-img.c
Expand Up @@ -1554,8 +1554,7 @@ static int img_convert(int argc, char **argv)
if (options) {
qemu_opts_do_parse(opts, options, NULL, &local_err);
if (local_err) {
error_report("Invalid options for file format '%s'", out_fmt);
error_free(local_err);
error_report_err(local_err);
ret = -1;
goto out;
}
Expand Down Expand Up @@ -3001,8 +3000,7 @@ static int img_amend(int argc, char **argv)
if (options) {
qemu_opts_do_parse(opts, options, NULL, &err);
if (err) {
error_report("Invalid options for file format '%s'", fmt);
error_free(err);
error_report_err(err);
ret = -1;
goto out;
}
Expand Down
1 change: 0 additions & 1 deletion tests/qemu-iotests/061.out
Expand Up @@ -288,7 +288,6 @@ qemu-img: Error while amending options: Invalid argument
Unknown compatibility level 0.42.
qemu-img: Error while amending options: Invalid argument
qemu-img: Invalid parameter 'foo'
qemu-img: Invalid options for file format 'qcow2'
Changing the cluster size is not supported.
qemu-img: Error while amending options: Operation not supported
Changing the encryption flag is not supported.
Expand Down

0 comments on commit 97a2ca7

Please sign in to comment.