Skip to content

Commit

Permalink
migration: Move migration_total_bytes() to migration-stats.c
Browse files Browse the repository at this point in the history
Once there rename it to migration_transferred_bytes() and pass a
QEMUFile instead of a migration object.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20230515195709.63843-7-quintela@redhat.com>
  • Loading branch information
Juan Quintela committed May 18, 2023
1 parent e1fde0e commit 99319e2
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 10 deletions.
5 changes: 5 additions & 0 deletions migration/migration-stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,8 @@ void migration_rate_account(uint64_t len)
{
stat64_add(&mig_stats.rate_limit_used, len);
}

uint64_t migration_transferred_bytes(QEMUFile *f)
{
return qemu_file_transferred(f) + stat64_get(&mig_stats.multifd_bytes);
}
11 changes: 11 additions & 0 deletions migration/migration-stats.h
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,15 @@ void migration_rate_reset(void);
* @new_rate: new maximum amount
*/
void migration_rate_set(uint64_t new_rate);

/**
* migration_transferred_bytes: Return number of bytes transferred
*
* @f: QEMUFile used for main migration channel
*
* Returns how many bytes have we transferred since the beginning of
* the migration. It accounts for bytes sent through any migration
* channel, multifd, qemu_file, rdma, ....
*/
uint64_t migration_transferred_bytes(QEMUFile *f);
#endif
13 changes: 3 additions & 10 deletions migration/migration.c
Original file line number Diff line number Diff line change
Expand Up @@ -2625,16 +2625,9 @@ static MigThrError migration_detect_error(MigrationState *s)
}
}

/* How many bytes have we transferred since the beginning of the migration */
static uint64_t migration_total_bytes(MigrationState *s)
{
return qemu_file_transferred(s->to_dst_file) +
stat64_get(&mig_stats.multifd_bytes);
}

static void migration_calculate_complete(MigrationState *s)
{
uint64_t bytes = migration_total_bytes(s);
uint64_t bytes = migration_transferred_bytes(s->to_dst_file);
int64_t end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
int64_t transfer_time;

Expand All @@ -2660,7 +2653,7 @@ static void update_iteration_initial_status(MigrationState *s)
* wrong speed calculation.
*/
s->iteration_start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
s->iteration_initial_bytes = migration_total_bytes(s);
s->iteration_initial_bytes = migration_transferred_bytes(s->to_dst_file);
s->iteration_initial_pages = ram_get_total_transferred_pages();
}

Expand All @@ -2675,7 +2668,7 @@ static void migration_update_counters(MigrationState *s,
return;
}

current_bytes = migration_total_bytes(s);
current_bytes = migration_transferred_bytes(s->to_dst_file);
transferred = current_bytes - s->iteration_initial_bytes;
time_spent = current_time - s->iteration_start_time;
bandwidth = (double)transferred / time_spent;
Expand Down

0 comments on commit 99319e2

Please sign in to comment.