Skip to content

Commit

Permalink
tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp
Browse files Browse the repository at this point in the history
These tests' setUp do not do anything beyong what their base class do.
And while they do decorate the setUp() we can decorate the classes
instead, so no functionality is lost here.

This is possible because since Avocado 76.0 we can decorate setUp()
directly.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210415215141.1865467-4-crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
[PMD: added note to commit message about Avocado feature/version]
Signed-off-by: Cleber Rosa <crosa@redhat.com>
  • Loading branch information
clebergnu committed Jul 13, 2021
1 parent 414e9ae commit 9a94d8a
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions tests/acceptance/linux_ssh_mips_malta.py
Expand Up @@ -19,6 +19,8 @@
from avocado.utils import ssh


@skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
@skipUnless(ssh.SSH_CLIENT_BINARY, 'No SSH client available')
class LinuxSSH(Test, LinuxSSHMixIn):

timeout = 150 # Not for 'configure --enable-debug --enable-debug-tcg'
Expand Down Expand Up @@ -65,11 +67,6 @@ def get_kernel_info(self, endianess, wordsize):
kernel_hash = self.IMAGE_INFO[endianess]['kernel_hash'][wordsize]
return kernel_url, kernel_hash

@skipUnless(ssh.SSH_CLIENT_BINARY, 'No SSH client available')
@skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
def setUp(self):
super(LinuxSSH, self).setUp()

def ssh_disconnect_vm(self):
self.ssh_session.quit()

Expand Down

0 comments on commit 9a94d8a

Please sign in to comment.