Skip to content

Commit

Permalink
dma: Convert dma_aiocb_info.cancel to .cancel_async
Browse files Browse the repository at this point in the history
Just forward the request to bdrv_aio_cancel_async.

Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  • Loading branch information
Fam Zheng authored and stefanhaRH committed Sep 22, 2014
1 parent 771b64d commit 9bb9da4
Showing 1 changed file with 4 additions and 16 deletions.
20 changes: 4 additions & 16 deletions dma-helpers.c
Expand Up @@ -73,7 +73,6 @@ typedef struct {
QEMUSGList *sg;
uint64_t sector_num;
DMADirection dir;
bool in_cancel;
int sg_cur_index;
dma_addr_t sg_cur_byte;
QEMUIOVector iov;
Expand Down Expand Up @@ -125,12 +124,7 @@ static void dma_complete(DMAAIOCB *dbs, int ret)
qemu_bh_delete(dbs->bh);
dbs->bh = NULL;
}
if (!dbs->in_cancel) {
/* Requests may complete while dma_aio_cancel is in progress. In
* this case, the AIOCB should not be released because it is still
* referenced by dma_aio_cancel. */
qemu_aio_release(dbs);
}
qemu_aio_release(dbs);
}

static void dma_bdrv_cb(void *opaque, int ret)
Expand Down Expand Up @@ -186,19 +180,14 @@ static void dma_aio_cancel(BlockDriverAIOCB *acb)
trace_dma_aio_cancel(dbs);

if (dbs->acb) {
BlockDriverAIOCB *acb = dbs->acb;
dbs->acb = NULL;
dbs->in_cancel = true;
bdrv_aio_cancel(acb);
dbs->in_cancel = false;
bdrv_aio_cancel_async(dbs->acb);
}
dbs->common.cb = NULL;
dma_complete(dbs, 0);
}


static const AIOCBInfo dma_aiocb_info = {
.aiocb_size = sizeof(DMAAIOCB),
.cancel = dma_aio_cancel,
.cancel_async = dma_aio_cancel,
};

BlockDriverAIOCB *dma_bdrv_io(
Expand All @@ -217,7 +206,6 @@ BlockDriverAIOCB *dma_bdrv_io(
dbs->sg_cur_index = 0;
dbs->sg_cur_byte = 0;
dbs->dir = dir;
dbs->in_cancel = false;
dbs->io_func = io_func;
dbs->bh = NULL;
qemu_iovec_init(&dbs->iov, sg->nsg);
Expand Down

0 comments on commit 9bb9da4

Please sign in to comment.