Skip to content

Commit

Permalink
kvm: extend kvm_irqchip_add_msi_route to work on s390
Browse files Browse the repository at this point in the history
on s390 MSI-X irqs are presented as thin or adapter interrupts
for this we have to reorganize the routing entry to contain
valid information for the adapter interrupt code on s390.
To minimize impact on existing code we introduce an architecture
function to fixup the routing entry.

Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
  • Loading branch information
Frank Blaschka authored and cohuck committed Jan 12, 2015
1 parent 863f6f5 commit 9e03a04
Show file tree
Hide file tree
Showing 7 changed files with 61 additions and 0 deletions.
4 changes: 4 additions & 0 deletions include/sysemu/kvm.h
Expand Up @@ -158,6 +158,7 @@ extern bool kvm_readonly_mem_allowed;

struct kvm_run;
struct kvm_lapic_state;
struct kvm_irq_routing_entry;

typedef struct KVMCapabilityInfo {
const char *name;
Expand Down Expand Up @@ -270,6 +271,9 @@ int kvm_arch_on_sigbus(int code, void *addr);

void kvm_arch_init_irq_routing(KVMState *s);

int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
uint64_t address, uint32_t data);

int kvm_set_irq(KVMState *s, int irq, int level);
int kvm_irqchip_send_msi(KVMState *s, MSIMessage msg);

Expand Down
7 changes: 7 additions & 0 deletions kvm-all.c
Expand Up @@ -1225,6 +1225,10 @@ int kvm_irqchip_add_msi_route(KVMState *s, MSIMessage msg)
kroute.u.msi.address_lo = (uint32_t)msg.address;
kroute.u.msi.address_hi = msg.address >> 32;
kroute.u.msi.data = le32_to_cpu(msg.data);
if (kvm_arch_fixup_msi_route(&kroute, msg.address, msg.data)) {
kvm_irqchip_release_virq(s, virq);
return -EINVAL;
}

kvm_add_routing_entry(s, &kroute);
kvm_irqchip_commit_routes(s);
Expand All @@ -1250,6 +1254,9 @@ int kvm_irqchip_update_msi_route(KVMState *s, int virq, MSIMessage msg)
kroute.u.msi.address_lo = (uint32_t)msg.address;
kroute.u.msi.address_hi = msg.address >> 32;
kroute.u.msi.data = le32_to_cpu(msg.data);
if (kvm_arch_fixup_msi_route(&kroute, msg.address, msg.data)) {
return -EINVAL;
}

return kvm_update_routing_entry(s, &kroute);
}
Expand Down
6 changes: 6 additions & 0 deletions target-arm/kvm.c
Expand Up @@ -548,3 +548,9 @@ int kvm_arch_irqchip_create(KVMState *s)

return 0;
}

int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
uint64_t address, uint32_t data)
{
return 0;
}
6 changes: 6 additions & 0 deletions target-i386/kvm.c
Expand Up @@ -2733,3 +2733,9 @@ int kvm_device_msix_deassign(KVMState *s, uint32_t dev_id)
return kvm_deassign_irq_internal(s, dev_id, KVM_DEV_IRQ_GUEST_MSIX |
KVM_DEV_IRQ_HOST_MSIX);
}

int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
uint64_t address, uint32_t data)
{
return 0;
}
6 changes: 6 additions & 0 deletions target-mips/kvm.c
Expand Up @@ -688,3 +688,9 @@ int kvm_arch_get_registers(CPUState *cs)

return ret;
}

int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
uint64_t address, uint32_t data)
{
return 0;
}
6 changes: 6 additions & 0 deletions target-ppc/kvm.c
Expand Up @@ -2402,3 +2402,9 @@ void kvmppc_hash64_write_pte(CPUPPCState *env, target_ulong pte_index,
error_out:
return;
}

int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
uint64_t address, uint32_t data)
{
return 0;
}
26 changes: 26 additions & 0 deletions target-s390x/kvm.c
Expand Up @@ -41,6 +41,7 @@
#include "trace.h"
#include "qapi-event.h"
#include "hw/s390x/s390-pci-inst.h"
#include "hw/s390x/s390-pci-bus.h"

/* #define DEBUG_KVM */

Expand Down Expand Up @@ -1544,3 +1545,28 @@ int kvm_s390_set_cpu_state(S390CPU *cpu, uint8_t cpu_state)

return ret;
}

int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
uint64_t address, uint32_t data)
{
S390PCIBusDevice *pbdev;
uint32_t fid = data >> ZPCI_MSI_VEC_BITS;
uint32_t vec = data & ZPCI_MSI_VEC_MASK;

pbdev = s390_pci_find_dev_by_fid(fid);
if (!pbdev) {
DPRINTF("add_msi_route no dev\n");
return -ENODEV;
}

pbdev->routes.adapter.ind_offset = vec;

route->type = KVM_IRQ_ROUTING_S390_ADAPTER;
route->flags = 0;
route->u.adapter.summary_addr = pbdev->routes.adapter.summary_addr;
route->u.adapter.ind_addr = pbdev->routes.adapter.ind_addr;
route->u.adapter.summary_offset = pbdev->routes.adapter.summary_offset;
route->u.adapter.ind_offset = pbdev->routes.adapter.ind_offset;
route->u.adapter.adapter_id = pbdev->routes.adapter.adapter_id;
return 0;
}

0 comments on commit 9e03a04

Please sign in to comment.