Skip to content

Commit

Permalink
trans_rvv.c.inc: set vstart = 0 in int scalar move insns
Browse files Browse the repository at this point in the history
trans_vmv_x_s, trans_vmv_s_x, trans_vfmv_f_s and trans_vfmv_s_f aren't
setting vstart = 0 after execution. This is usually done by a helper in
vector_helper.c but these functions don't use helpers.

We'll set vstart after any potential 'over' brconds, and that will also
mandate a mark_vs_dirty() too.

Fixes: dedc53c ("target/riscv: rvv-1.0: integer scalar move instructions")
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-ID: <20240314175704.478276-3-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
(cherry picked from commit 0848f7c)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  • Loading branch information
danielhb authored and Michael Tokarev committed Mar 27, 2024
1 parent bf26b6a commit 9f0db88
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions target/riscv/insn_trans/trans_rvv.c.inc
Original file line number Diff line number Diff line change
Expand Up @@ -3360,6 +3360,8 @@ static bool trans_vmv_x_s(DisasContext *s, arg_vmv_x_s *a)
vec_element_loadi(s, t1, a->rs2, 0, true);
tcg_gen_trunc_i64_tl(dest, t1);
gen_set_gpr(s, a->rd, dest);
tcg_gen_movi_tl(cpu_vstart, 0);
mark_vs_dirty(s);
return true;
}
return false;
Expand All @@ -3386,8 +3388,9 @@ static bool trans_vmv_s_x(DisasContext *s, arg_vmv_s_x *a)
s1 = get_gpr(s, a->rs1, EXT_NONE);
tcg_gen_ext_tl_i64(t1, s1);
vec_element_storei(s, a->rd, 0, t1);
mark_vs_dirty(s);
gen_set_label(over);
tcg_gen_movi_tl(cpu_vstart, 0);
mark_vs_dirty(s);
return true;
}
return false;
Expand All @@ -3414,6 +3417,8 @@ static bool trans_vfmv_f_s(DisasContext *s, arg_vfmv_f_s *a)
}

mark_fs_dirty(s);
tcg_gen_movi_tl(cpu_vstart, 0);
mark_vs_dirty(s);
return true;
}
return false;
Expand All @@ -3439,8 +3444,9 @@ static bool trans_vfmv_s_f(DisasContext *s, arg_vfmv_s_f *a)
do_nanbox(s, t1, cpu_fpr[a->rs1]);

vec_element_storei(s, a->rd, 0, t1);
mark_vs_dirty(s);
gen_set_label(over);
tcg_gen_movi_tl(cpu_vstart, 0);
mark_vs_dirty(s);
return true;
}
return false;
Expand Down

0 comments on commit 9f0db88

Please sign in to comment.