Skip to content

Commit

Permalink
nbd: remove incorrect coroutine_fn annotations
Browse files Browse the repository at this point in the history
nbd_co_establish_connection_cancel() cancels a coroutine but is not called
from coroutine context itself, for example in nbd_cancel_in_flight()
and in timer callbacks reconnect_delay_timer_cb() and open_timer_cb().

Reviewed-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20220922084924.201610-5-pbonzini@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  • Loading branch information
bonzini authored and kevmw committed Oct 7, 2022
1 parent 3840144 commit 9fb2629
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/block/nbd.h
Expand Up @@ -424,6 +424,6 @@ QIOChannel *coroutine_fn
nbd_co_establish_connection(NBDClientConnection *conn, NBDExportInfo *info,
bool blocking, Error **errp);

void coroutine_fn nbd_co_establish_connection_cancel(NBDClientConnection *conn);
void nbd_co_establish_connection_cancel(NBDClientConnection *conn);

#endif

0 comments on commit 9fb2629

Please sign in to comment.