Skip to content

Commit

Permalink
tests/migration-test: Fix "true" vs true
Browse files Browse the repository at this point in the history
Accidental use of "true" as a boolean; spotted by coverity
and Peter.

Fixes: b99784e
Fixes: d795f47
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Reported-by: Coverity (CID 1432373, 1432292, 1432288)
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20210504100545.112213-1-dgilbert@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  • Loading branch information
dagrh committed May 13, 2021
1 parent 542147f commit a1209bb
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions tests/qtest/migration-test.c
Expand Up @@ -898,8 +898,8 @@ static void test_xbzrle(const char *uri)

migrate_set_parameter_int(from, "xbzrle-cache-size", 33554432);

migrate_set_capability(from, "xbzrle", "true");
migrate_set_capability(to, "xbzrle", "true");
migrate_set_capability(from, "xbzrle", true);
migrate_set_capability(to, "xbzrle", true);
/* Wait for the first serial output from the source */
wait_for_serial("src_serial");

Expand Down Expand Up @@ -1246,8 +1246,8 @@ static void test_multifd_tcp(const char *method)
migrate_set_parameter_str(from, "multifd-compression", method);
migrate_set_parameter_str(to, "multifd-compression", method);

migrate_set_capability(from, "multifd", "true");
migrate_set_capability(to, "multifd", "true");
migrate_set_capability(from, "multifd", true);
migrate_set_capability(to, "multifd", true);

/* Start incoming migration from the 1st socket */
rsp = wait_command(to, "{ 'execute': 'migrate-incoming',"
Expand Down Expand Up @@ -1330,8 +1330,8 @@ static void test_multifd_tcp_cancel(void)
migrate_set_parameter_int(from, "multifd-channels", 16);
migrate_set_parameter_int(to, "multifd-channels", 16);

migrate_set_capability(from, "multifd", "true");
migrate_set_capability(to, "multifd", "true");
migrate_set_capability(from, "multifd", true);
migrate_set_capability(to, "multifd", true);

/* Start incoming migration from the 1st socket */
rsp = wait_command(to, "{ 'execute': 'migrate-incoming',"
Expand All @@ -1358,7 +1358,7 @@ static void test_multifd_tcp_cancel(void)

migrate_set_parameter_int(to2, "multifd-channels", 16);

migrate_set_capability(to2, "multifd", "true");
migrate_set_capability(to2, "multifd", true);

/* Start incoming migration from the 1st socket */
rsp = wait_command(to2, "{ 'execute': 'migrate-incoming',"
Expand Down

0 comments on commit a1209bb

Please sign in to comment.