Skip to content

Commit

Permalink
Revert "tests/qtest/netdev-socket: Raise connection timeout to 120 se…
Browse files Browse the repository at this point in the history
…conds"

This reverts commit 0daaf27.

The test was not timing out because of slow execution. It was
timing out due to a race condition leading to the client QEMU
attempting (and fatally failing) to connect before the server
QEMU was listening.

Signed-off-by: "Daniel P. Berrangé" <berrange@redhat.com>
Message-ID: <20240104162942.211458-4-berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
berrange authored and huth committed Jan 11, 2024
1 parent 1a2253c commit a298293
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/qtest/netdev-socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include "qapi/qobject-input-visitor.h"
#include "qapi/qapi-visit-sockets.h"

#define CONNECTION_TIMEOUT 120
#define CONNECTION_TIMEOUT 60

#define EXPECT_STATE(q, e, t) \
do { \
Expand Down

0 comments on commit a298293

Please sign in to comment.