Skip to content

Commit

Permalink
tools/virtiofsd: Replace the word 'whitelist'
Browse files Browse the repository at this point in the history
Follow the inclusive terminology from the "Conscious Language in your
Open Source Projects" guidelines [*] and replace the words "whitelist"
appropriately.

[*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210205171817.2108907-3-philmd@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  • Loading branch information
philmd authored and dagrh committed Feb 16, 2021
1 parent 525a303 commit a65963e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions tools/virtiofsd/passthrough_ll.c
Expand Up @@ -3204,7 +3204,7 @@ static void setup_mounts(const char *source)
}

/*
* Only keep whitelisted capabilities that are needed for file system operation
* Only keep capabilities in allowlist that are needed for file system operation
* The (possibly NULL) modcaps_in string passed in is free'd before exit.
*/
static void setup_capabilities(char *modcaps_in)
Expand All @@ -3214,8 +3214,8 @@ static void setup_capabilities(char *modcaps_in)
capng_restore_state(&cap.saved);

/*
* Whitelist file system-related capabilities that are needed for a file
* server to act like root. Drop everything else like networking and
* Add to allowlist file system-related capabilities that are needed for a
* file server to act like root. Drop everything else like networking and
* sysadmin capabilities.
*
* Exclusions:
Expand Down
12 changes: 6 additions & 6 deletions tools/virtiofsd/passthrough_seccomp.c
Expand Up @@ -21,7 +21,7 @@
#endif
#endif

static const int syscall_whitelist[] = {
static const int syscall_allowlist[] = {
/* TODO ireg sem*() syscalls */
SCMP_SYS(brk),
SCMP_SYS(capget), /* For CAP_FSETID */
Expand Down Expand Up @@ -117,12 +117,12 @@ static const int syscall_whitelist[] = {
};

/* Syscalls used when --syslog is enabled */
static const int syscall_whitelist_syslog[] = {
static const int syscall_allowlist_syslog[] = {
SCMP_SYS(send),
SCMP_SYS(sendto),
};

static void add_whitelist(scmp_filter_ctx ctx, const int syscalls[], size_t len)
static void add_allowlist(scmp_filter_ctx ctx, const int syscalls[], size_t len)
{
size_t i;

Expand Down Expand Up @@ -153,10 +153,10 @@ void setup_seccomp(bool enable_syslog)
exit(1);
}

add_whitelist(ctx, syscall_whitelist, G_N_ELEMENTS(syscall_whitelist));
add_allowlist(ctx, syscall_allowlist, G_N_ELEMENTS(syscall_allowlist));
if (enable_syslog) {
add_whitelist(ctx, syscall_whitelist_syslog,
G_N_ELEMENTS(syscall_whitelist_syslog));
add_allowlist(ctx, syscall_allowlist_syslog,
G_N_ELEMENTS(syscall_allowlist_syslog));
}

/* libvhost-user calls this for post-copy migration, we don't need it */
Expand Down

0 comments on commit a65963e

Please sign in to comment.