Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
qapi: Improve reporting of invalid flags
Split check_flags() off check_keys() and have check_exprs() call it later, so its error messages gain an "in definition" line. Tweak the error messages. Checking values in a function named check_keys() is unclean anyway. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20190927134639.4284-20-armbru@redhat.com>
- Loading branch information
Markus Armbruster
committed
Sep 28, 2019
1 parent
576f0b8
commit a6735a5
Showing
5 changed files
with
20 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
tests/qapi-schema/allow-preconfig-test.json:2: 'allow-preconfig' of command 'allow-preconfig-test' should only use true value | ||
tests/qapi-schema/allow-preconfig-test.json: In command 'allow-preconfig-test': | ||
tests/qapi-schema/allow-preconfig-test.json:2: flag 'allow-preconfig' may only use true value |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
tests/qapi-schema/args-bad-boxed.json:2: 'boxed' of command 'foo' should only use true value | ||
tests/qapi-schema/args-bad-boxed.json: In command 'foo': | ||
tests/qapi-schema/args-bad-boxed.json:2: flag 'boxed' may only use true value |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
tests/qapi-schema/oob-test.json:2: 'allow-oob' of command 'oob-command-1' should only use true value | ||
tests/qapi-schema/oob-test.json: In command 'oob-command-1': | ||
tests/qapi-schema/oob-test.json:2: flag 'allow-oob' may only use true value |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
tests/qapi-schema/type-bypass-bad-gen.json:2: 'gen' of command 'foo' should only use false value | ||
tests/qapi-schema/type-bypass-bad-gen.json: In command 'foo': | ||
tests/qapi-schema/type-bypass-bad-gen.json:2: flag 'gen' may only use false value |