Skip to content

Commit

Permalink
hw/cpu: Update the comments of nr_cores and nr_dies
Browse files Browse the repository at this point in the history
In the nr_threads' comment, specify it represents the
number of threads in the "core" to avoid confusion.

Also add comment for nr_dies in CPUX86State.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Babu Moger <babu.moger@amd.com>
Tested-by: Yongwei Ma <yongwei.ma@intel.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-ID: <20231024090323.1859210-5-zhao1.liu@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
  • Loading branch information
trueptolemy authored and philmd committed Nov 7, 2023
1 parent 958ac3c commit aa1878f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion include/hw/core/cpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ struct qemu_work_item;
* See TranslationBlock::TCG CF_CLUSTER_MASK.
* @tcg_cflags: Pre-computed cflags for this cpu.
* @nr_cores: Number of cores within this CPU package.
* @nr_threads: Number of threads within this CPU.
* @nr_threads: Number of threads within this CPU core.
* @running: #true if CPU is currently running (lockless).
* @has_waiter: #true if a CPU is currently waiting for the cpu_exec_end;
* valid under cpu_list_lock.
Expand Down
1 change: 1 addition & 0 deletions target/i386/cpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -1882,6 +1882,7 @@ typedef struct CPUArchState {

TPRAccess tpr_access_type;

/* Number of dies within this CPU package. */
unsigned nr_dies;
} CPUX86State;

Expand Down

0 comments on commit aa1878f

Please sign in to comment.