Skip to content

Commit

Permalink
audio: Require AudioState in AUD_add_capture
Browse files Browse the repository at this point in the history
Since all callers require a valid audiodev this function can now safely
abort in case of missing AudioState.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Message-ID: <c6e87e678e914df0f59da2145c2753cdb4a16f63.1650874791.git.mkletzan@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
nertpinx authored and bonzini committed Oct 3, 2023
1 parent 9e58d7a commit aaa6a6f
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions audio/audio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1876,10 +1876,8 @@ CaptureVoiceOut *AUD_add_capture(
struct capture_callback *cb;

if (!s) {
if (!legacy_config) {
dolog("Capturing without setting an audiodev is deprecated\n");
}
s = audio_init(NULL, NULL);
error_report("Capturing without setting an audiodev is not supported");
abort();
}

if (!audio_get_pdo_out(s->dev)->mixing_engine) {
Expand Down

0 comments on commit aaa6a6f

Please sign in to comment.