Skip to content

Commit

Permalink
arm_gicv3: Add assert()s to tell Coverity that offsets are aligned
Browse files Browse the repository at this point in the history
Coverity complains that the GICR_IPRIORITYR case in gicv3_readl()
can overflow an array, because it doesn't know that the offsets
passed to that function must be word aligned. Add some assert()s
which hopefully tell Coverity that this isn't possible.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1468261372-17508-1-git-send-email-peter.maydell@linaro.org
  • Loading branch information
pm215 committed Jul 19, 2016
1 parent ff9d3e9 commit acd8279
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions hw/intc/arm_gicv3_redist.c
Expand Up @@ -420,6 +420,8 @@ MemTxResult gicv3_redist_read(void *opaque, hwaddr offset, uint64_t *data,
MemTxResult r;
int cpuidx;

assert((offset & (size - 1)) == 0);

/* This region covers all the redistributor pages; there are
* (for GICv3) two 64K pages per CPU. At the moment they are
* all contiguous (ie in this one region), though we might later
Expand Down Expand Up @@ -468,6 +470,8 @@ MemTxResult gicv3_redist_write(void *opaque, hwaddr offset, uint64_t data,
MemTxResult r;
int cpuidx;

assert((offset & (size - 1)) == 0);

/* This region covers all the redistributor pages; there are
* (for GICv3) two 64K pages per CPU. At the moment they are
* all contiguous (ie in this one region), though we might later
Expand Down

0 comments on commit acd8279

Please sign in to comment.