Skip to content

Commit

Permalink
kvm: drop no-op MemoryListener callbacks
Browse files Browse the repository at this point in the history
Removes quite a bit of useless code.

Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
avikivity committed Oct 15, 2012
1 parent 6381fc1 commit ad1ff3d
Showing 1 changed file with 0 additions and 30 deletions.
30 changes: 0 additions & 30 deletions kvm-all.c
Expand Up @@ -703,14 +703,6 @@ static void kvm_set_phys_mem(MemoryRegionSection *section, bool add)
}
}

static void kvm_begin(MemoryListener *listener)
{
}

static void kvm_commit(MemoryListener *listener)
{
}

static void kvm_region_add(MemoryListener *listener,
MemoryRegionSection *section)
{
Expand All @@ -723,11 +715,6 @@ static void kvm_region_del(MemoryListener *listener,
kvm_set_phys_mem(section, false);
}

static void kvm_region_nop(MemoryListener *listener,
MemoryRegionSection *section)
{
}

static void kvm_log_sync(MemoryListener *listener,
MemoryRegionSection *section)
{
Expand Down Expand Up @@ -755,10 +742,6 @@ static void kvm_log_global_stop(struct MemoryListener *listener)
assert(r >= 0);
}

static void kvm_log_nop(struct MemoryListener *listener)
{
}

static void kvm_mem_ioeventfd_add(MemoryListener *listener,
MemoryRegionSection *section,
bool match_data, uint64_t data,
Expand Down Expand Up @@ -825,11 +808,8 @@ static void kvm_io_ioeventfd_del(MemoryListener *listener,
}

static MemoryListener kvm_memory_listener = {
.begin = kvm_begin,
.commit = kvm_commit,
.region_add = kvm_region_add,
.region_del = kvm_region_del,
.region_nop = kvm_region_nop,
.log_start = kvm_log_start,
.log_stop = kvm_log_stop,
.log_sync = kvm_log_sync,
Expand All @@ -841,16 +821,6 @@ static MemoryListener kvm_memory_listener = {
};

static MemoryListener kvm_io_listener = {
.begin = kvm_begin,
.commit = kvm_commit,
.region_add = kvm_region_nop,
.region_del = kvm_region_nop,
.region_nop = kvm_region_nop,
.log_start = kvm_region_nop,
.log_stop = kvm_region_nop,
.log_sync = kvm_region_nop,
.log_global_start = kvm_log_nop,
.log_global_stop = kvm_log_nop,
.eventfd_add = kvm_io_ioeventfd_add,
.eventfd_del = kvm_io_ioeventfd_del,
.priority = 10,
Expand Down

0 comments on commit ad1ff3d

Please sign in to comment.